2967: RBTools

sudhir.********@gmai***** (Google Code) (Is this you? Claim this profile.)
smacleod
May 8, 2013
What version are you running?
RBTools 0.5

What's the URL of the page containing the problem?
None

What steps will reproduce the problem?
1. 'rbt post' for subversion client will result in below code failure
TypeError: can only concatenate list (not "tuple") to list


What is the expected output?
Successful 'rbt post'



Please provide any additional information below.

Below is the code fix. 
======================
sudhirbs@rhel-sudhirbs 0.5.0.1 $ svn diff
Index: clients/svn.py
===================================================================
--- clients/svn.py      (revision 400024)
+++ clients/svn.py      (working copy)
@@ -105,7 +105,7 @@
         makes parent diffs possible, so we never return a parent diff
         (the second value in the tuple).
         """
-        return (self.do_diff(["svn", "diff", "--diff-cmd=diff"] + files),
+        return (self.do_diff(["svn", "diff", "--diff-cmd=diff"] + list(files)),
                 None)

     def diff_changelist(self, changelist):
david
#1 david
  • +Component-RBTools
  • +smacleod
#2 smacleod
Fix for review: http://reviews.reviewboard.org/r/4111/
  • +PendingReview
#3 smacleod
Fixed in master and release-0.5.x (a8f4db54db3fe1058423c7280c5b825016edeeff)
  • -PendingReview
    +Fixed