generate url dynamically
Review Request #3386 — Created Sept. 29, 2012 and submitted
generate url dynamically. This requires that the site name be set in the db because it is set to example.com by default Also use findhostname() and AGENT
| Description | From | Last Updated |
|---|---|---|
|
We should probably use the celery worker hostname, not the systems. The worker can be started with an different hostname … |
SM smacleod | |
|
The imports should be ordered alphabetically. |
SM smacleod | |
|
This import should be after the imports from celery, but before reviewboard. |
SM smacleod | |
|
No blank line here. |
SM smacleod | |
|
Can you end this line with a comma please. |
SM smacleod | |
|
We need a newline at the end of the file. |
SM smacleod | |
|
Can you make this a proper sentence with a period. |
SM smacleod |
SM
-
-
bot/reviewbot/tasks.py (Diff revision 1) We should probably use the celery worker hostname, not the systems. The worker can be started with an different hostname by providing '-n <hostname>'
-
-
extension/reviewbotext/extension.py (Diff revision 1) This import should be after the imports from celery, but before reviewboard.
-
-
-
SM
-
The patch isn't applying cleanly. Could you merge in the latest master and update the request. Other than my one nit-pick, this is ready to go in.
-
extension/reviewbotext/extension.py (Diff revision 4) Can you make this a proper sentence with a period.
SM
-
This still isn't applying cleanly, it looks like the patch is based off of an older commit. Please pull the latest changes from the ReviewBot repo, merge master into your branch, and update the request.