generate url dynamically

Review Request #3386 — Created Sept. 29, 2012 and submitted

tahnok
ReviewBot
smacleod
generate url dynamically. This requires that the site name be set in the db because it is set to example.com by default

Also use findhostname() and AGENT


Description From Last Updated

We should probably use the celery worker hostname, not the systems. The worker can be started with an different hostname ...

SM smacleod

The imports should be ordered alphabetically.

SM smacleod

This import should be after the imports from celery, but before reviewboard.

SM smacleod

No blank line here.

SM smacleod

Can you end this line with a comma please.

SM smacleod

We need a newline at the end of the file.

SM smacleod

Can you make this a proper sentence with a period.

SM smacleod
TA
TA
SM
  1. 
      
  2. bot/reviewbot/tasks.py (Diff revision 1)
     
     
    We should probably use the celery worker hostname, not the systems. The worker can be started with an different hostname by providing  '-n <hostname>'
  3. extension/reviewbotext/extension.py (Diff revision 1)
     
     
    The imports should be ordered alphabetically.
  4. extension/reviewbotext/extension.py (Diff revision 1)
     
     
    This import should be after the imports from celery, but before reviewboard.
  5. extension/reviewbotext/extension.py (Diff revision 1)
     
     
    No blank line here.
  6. extension/reviewbotext/extension.py (Diff revision 1)
     
     
    Can you end this line with a comma please.
  7. extension/reviewbotext/extension.py (Diff revision 1)
     
     
    We need a newline at the end of the file.
    1. There IS a newline at the end of the file... not sure why you can't see it
  8. 
      
TA
TA
TA
SM
  1. The patch isn't applying cleanly. Could you merge in the latest master and update the request.
    
    Other than my one nit-pick, this is ready to go in.
  2. extension/reviewbotext/extension.py (Diff revision 4)
     
     
    Can you make this a proper sentence with a period.
  3. 
      
TA
SM
  1. This still isn't applying cleanly, it looks like the patch is based off
    of an older commit. Please pull the latest changes from the ReviewBot
    repo, merge master into your branch, and update the request.
  2. 
      
TA
SM
  1. Ship It!
  2. 
      
TA
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master at http://github.com/smacleod/ReviewBot/ (95cab4623a)
Loading...