This change has been marked as completed.

Describe the completed change (optional):

Pushed to master at http://github.com/smacleod/ReviewBot/ (95cab4623a)

Summary

generate url dynamically

Review Request #3386 — Created Sept. 29, 2012 and submitted 12 years, 7 months ago

Information

Owner

tahnok*

Repository

ReviewBot

Branch

Bugs

Depends On

Reviewers

Groups

People

smacleod

Description*

generate url dynamically. This requires that the site name be set in the db because it is set to example.com by default

Also use findhostname() and AGENT

Testing Done

Issues

Description	From	Last Updated
We should probably use the celery worker hostname, not the systems. The worker can be started with an different hostname …	SM smacleod	12 years, 7 months ago
The imports should be ordered alphabetically.	SM smacleod	12 years, 8 months ago
This import should be after the imports from celery, but before reviewboard.	SM smacleod	12 years, 8 months ago
No blank line here.	SM smacleod	12 years, 8 months ago
Can you end this line with a comma please.	SM smacleod	12 years, 8 months ago
We need a newline at the end of the file.	SM smacleod	12 years, 8 months ago
Can you make this a proper sentence with a period.	SM smacleod	12 years, 7 months ago
There are no open issues

People:: smacleod

bot/reviewbot/tasks.py (Diff revision 1)

The issue has been resolved. Show all issues

We should probably use the celery worker hostname, not the systems. The worker can be started with an different hostname by providing  '-n <hostname>'

extension/reviewbotext/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
The imports should be ordered alphabetically.
```
extension/reviewbotext/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This import should be after the imports from celery, but before reviewboard.
```
extension/reviewbotext/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
No blank line here.
```
extension/reviewbotext/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can you end this line with a comma please.
```
extension/reviewbotext/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
We need a newline at the end of the file.
```
1. TA
  
  tahnok 12 years, 8 months ago
  There IS a newline at the end of the file... not sure why you can't see it

Diff:

Revision 2 (+20 -12)

Show changes

	.gitignore
	bot/reviewbot/tasks.py
	extension/reviewbotext/extension.py
	extension/reviewbotext/forms.py

Diff:

Revision 3 (+25 -12)

Show changes

	.gitignore
	reviewbot-cookies.txt
	bot/reviewbot/tasks.py
	extension/reviewbotext/extension.py
	extension/reviewbotext/forms.py

Diff:

Revision 4 (+20 -12)

Show changes

	.gitignore
	bot/reviewbot/tasks.py
	extension/reviewbotext/extension.py
	extension/reviewbotext/forms.py

The patch isn't applying cleanly. Could you merge in the latest master and update the request.

Other than my one nit-pick, this is ready to go in.

extension/reviewbotext/extension.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Can you make this a proper sentence with a period.
```

Diff:

Revision 5 (+20 -12)

Show changes

	.gitignore
	bot/reviewbot/tasks.py
	extension/reviewbotext/extension.py
	extension/reviewbotext/forms.py

This still isn't applying cleanly, it looks like the patch is based off
of an older commit. Please pull the latest changes from the ReviewBot
repo, merge master into your branch, and update the request.

Diff:

Revision 6 (+20 -12)

Show changes

	.gitignore
	bot/reviewbot/tasks.py
	extension/reviewbotext/extension.py
	extension/reviewbotext/forms.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master at http://github.com/smacleod/ReviewBot/ (95cab4623a)