This change has been discarded.

Describe the reason it's discarded (optional):

These days, we strongly encourage using name-based lookups, so the URL shouldn't matter anymore.

Summary

add support for https:// based repositories at github

Review Request #3277 — Created Aug. 14, 2012 and discarded 11 years, 5 months ago

Information

Owner

kofemann*

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description*

add support for https:// based repositories at github

Currently reviewboard's github hosting service supports only git:// repositories.
It would be nice to support https:// based repositories as well. This patch provides such functionality
by adding a drop-down list for github access protocols.

Testing Done

I am able to create a repository with https:// and post a review request with post-review tool. Deployed on reviewboard instance of dCache.ORG project ( http://rb.dcache.org ).

Issues

Description	From	Last Updated
No blank line.	chipx86	12 years, 10 months ago
You'll need to specify defaults on these, or all existing hosting service account entries will break. It should default to …	chipx86	12 years, 10 months ago
Might be nice to define these values once so they're not repeated.	chipx86	12 years, 10 months ago
No blank line.	chipx86	12 years, 10 months ago

Fix it!

This looks like a good thing to add. A few changes are needed, though, before we can commit it.

reviewboard/hostingsvcs/github.py (Diff revision 1)
The issue has been resolved. Show all issues
```
No blank line.
```

reviewboard/hostingsvcs/github.py (Diff revision 1)

An issue was opened. Show all issues

You'll need to specify defaults on these, or all existing hosting service account entries will break. It should default to 'git', since that's what was used before.

We'll also need to modify existing unit tests for the new field, and add two to verify existing accounts without this field produce the expected result (one per plan you've updated).

reviewboard/hostingsvcs/github.py (Diff revision 1)
An issue was opened. Show all issues
```
Might be nice to define these values once so they're not repeated.
```
reviewboard/hostingsvcs/github.py (Diff revision 1)
The issue has been resolved. Show all issues
```
No blank line.
```

Status:: Discarded
Change Summary:: These days, we strongly encourage using name-based lookups, so the URL shouldn't matter anymore.