add support for https:// based repositories at github

Review Request #3277 — Created Aug. 14, 2012 and discarded

Information

Review Board

Reviewers

add support for https:// based repositories at github

Currently reviewboard's github hosting service supports only git:// repositories.
It would be nice to support https:// based repositories as well. This patch provides such functionality
by adding a drop-down list for github access protocols.
I am able to create a repository with https:// and post a review request with post-review tool. Deployed on reviewboard instance of dCache.ORG project ( http://rb.dcache.org ).
Description From Last Updated

No blank line.

chipx86chipx86

You'll need to specify defaults on these, or all existing hosting service account entries will break. It should default to …

chipx86chipx86

Might be nice to define these values once so they're not repeated.

chipx86chipx86

No blank line.

chipx86chipx86
chipx86
  1. This looks like a good thing to add. A few changes are needed, though, before we can commit it.
  2. reviewboard/hostingsvcs/github.py (Diff revision 1)
     
     
     
     
    No blank line.
  3. reviewboard/hostingsvcs/github.py (Diff revision 1)
     
     
     
    You'll need to specify defaults on these, or all existing hosting service account entries will break. It should default to 'git', since that's what was used before.
    
    We'll also need to modify existing unit tests for the new field, and add two to verify existing accounts without this field produce the expected result (one per plan you've updated).
  4. reviewboard/hostingsvcs/github.py (Diff revision 1)
     
     
     
    Might be nice to define these values once so they're not repeated.
  5. reviewboard/hostingsvcs/github.py (Diff revision 1)
     
     
     
     
    No blank line.
  6. 
      
kofemann
Review request changed

Status: Discarded

Change Summary:

These days, we strongly encourage using name-based lookups, so the URL shouldn't matter anymore.
Loading...