The yellow feels a bit jarring on this background. Can we turn it down? Maybe add a bit more padding too.

Hmm not sure a button is right for this, given that it changes states. A drop-down may be better.

First line summary, on the same line as """.

Then a blank line, then description.

css_class

No need for (), and don't use "not". Use !=.

Two blank lines.

Comparisons should actually use ===. No casting, so slightly faster. Same below.

Combine these lines.

Hmm, actually, I'm thinking we should just do an {% if %} here in place of the hide_not_open_issue filter. The filter seems a bit wrong here.

Aside from fixed issues blending in with the background and a background color for headers, there's a couple other finicky things.
If you exit the page it resets your "Show status" option, which could potentially be annoying (might be ok, wishful thinking?). Changing status' also changes the sorting of the summary table. Aesthetically think they should sort the same as the review.

It seems that the default method should be reachable again after sorting other columns.

th:first-child?

th:last-child?

Would it be useful to sort by description as well?

Additionally, should we restrict the headers explicitly or just specify all <th> in issue-table?

Extra space in front?

I'm wondering if this would make more sense, semantically, as a list or grouped in a stronger fashion.

Would it make sense to add some sort of delineation between a count and the next label (e.g., comma, vertical border)? I feel like it might be best to remove the temptation to read it as "n things" rather than "things: n".

Missing trans blocks?

If there are only two states (All, or Open), I wonder if we can simplify the interface by just using a checkbox?

Or maybe even better, just a link like we do in the review request dashboard ("Hide submitted", "Show submitted", etc).

Remind me again - do we wrap long comments like this?  Or truncate them?

ChipX86 / purple_cow might disagree with me here, but I think we might want a darker border around this table.

I'm curious - why is this defined as a new function instead of an object?  Could you not accomplish the same thing via:

var issueSummaryTableManager = {
  init: function() {
    // blah
  }
};

I believe .parent().children() can be simplified to just .siblings()

The way the columns expand like this seems strange to me. I feel like it would be better if the description field grew to take up the space, leaving the other columns fixed to the left and right.

It might be nice to have a horizontal rule between these sections. Like the ones that appear between Summary/Info, and Info/rest of request.

It isn't really part of the request's body like the other fields it is appearing with.

Can I see this with short descriptions?

I like it. Exactly what I meant.

I think it's much better now. Great job.

I think this is looking very good! A couple nits to pick, and then I'm happy if everyone else is happy.

These should align.

Blank line after variable declarations.

Blank line between these.

Align the parseInts.

Same.

As an optimization. pull out the text() results for each thing. Then compare these before doing any attr() or hasClass() comparisons (assuming that's not going to throw off the logic).

That should shorten the sort time for all this.

Can you make this !== && !== ?

Just easier to read.

Just curious - what's this column useful for?  Is that the comment id?  If so...I'm not sure that's information that's useful to me.

If that's true, we can axe that column.

Nit - the edges of these boxes don't line up.  The border around the lone file attachment does not line up with the left border of the issue table.

Another nit - are we able to make the Total / Show status labels line up with the left border of the table?

I applied this and spent some time playing with it. I like the direction a lot, but there's a style issue that's bothering me.

I think the table itself doesn't fit in well enough with Review Board right now. The reasons being that the font sizes are hard-coded to be larger than you'd find in other tables, and the alignment is centered, which you don't find elsewhere.

I'd like the font sizes to match that of the Dashboard, and for the content to be left-aligned.

I'd also be interested in seeing how the header looked in dashboard style, in order to be more consistent.

I think Christian made some good points. This fits in much better now.

Looks good, but no longer applies. Once it does I'll give it a final spin and then in it goes!

Bump - any chance you can unbitrot this patch, Yazan? When that's done, I think it's ready to go.

Ship It!