Support for Multiple SSH Keys via .ssh/config

Review Request #2391 — Created June 2, 2011 and discarded

Information
phil.orwig
Review Board
1.5.5
2123
Reviewers
reviewboard 
This patch allows paramiko to honor the IdentityFile settings for a host that have been set in the user's .ssh/config file.
Tested on a system without a .ssh/config file, on a system with a blank .ssh/config file, and on a system with a .ssh/config file with the appropriate settings for a host.
chipx86
chipx86 
  1. Awesome change. There's some style stuff to fix up, but otherwise, it looks pretty sound.

One big thing, though, is that we'll need this merged into master, and that'll require some additional work to take a local_site_name parameter in many functions.
  2. reviewboard/cmdline/rbssh.py (Diff revision 1) 
     
     
     
     
     
     
    I imagine this could be one statement. If identity_filename is None (or whatever the default would be for client.connect()), we could simply have one connect call.
  3. reviewboard/scmtools/sshutils.py (Diff revision 1) 
     
     
     
     
     
    Two blank lines between functions.
  4. reviewboard/scmtools/sshutils.py (Diff revision 1) 
     
     
     
     
     
    Two blank lines between functions.
  5. reviewboard/scmtools/sshutils.py (Diff revision 1) 
     
     
     
     
     
    Two blank lines between functions.
  6. reviewboard/scmtools/sshutils.py (Diff revision 1) 
     
     
     
    Trailing whitespace.
  7. reviewboard/scmtools/sshutils.py (Diff revision 1) 
     
     
     
     
    Blank line between these.
  8. reviewboard/scmtools/sshutils.py (Diff revision 1) 
     
     
     
    Can you do an explicit open and close on this? I think it'll leak otherwise.
  9. reviewboard/scmtools/sshutils.py (Diff revision 1) 
     
     
     
     
     
    Two blank lines between functions.
  10. reviewboard/scmtools/sshutils.py (Diff revision 1) 
     
     
     
     
    Blank line between these (should have one before blocks).
  11. reviewboard/scmtools/sshutils.py (Diff revision 1) 
     
     
     
     
    Here too.
  12. reviewboard/scmtools/sshutils.py (Diff revision 1) 
     
     
     
    Sentence casing for comments.
  13. reviewboard/scmtools/sshutils.py (Diff revision 1) 
     
     
     
     
     
     
    Could be one statement, like above.
  14. reviewboard/scmtools/sshutils.py (Diff revision 1) 
     
     
     
    Wrap to 80 chars
  15. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    16. 




  

 
















 



 

  

   





 PH





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Discarded

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...