2123: Support for Multiple SSH Keys

Phil.*****@gmai***** (Google Code) (Is this you? Claim this profile.)
What version are you running?
1.5.5

What's the URL of the page this enhancement relates to, if any?
/admin/db/scmtools/repository/

Describe the enhancement and the motivation for it.
Prior to the addition of rbssh, administrators were able to set per-host SSH keys via ~/.ssh/config.

What operating system are you using? What browser?
Server is running CentOS 5.  Browser is irrelevant for this.

Please provide any additional information below.
In the reviewboard user's .ssh/config file, one could add:

  Host svn.example.com
    IdentityFile ~/.ssh/svn.example.com.key

to set a custom key for a particular server, while still allowing the default .ssh/id_dsa key for other hosts.  Paramiko appears to support SSH config files, and should allow rbssh to use the .ssh/config file.  Unfortunately, sshutils doesn't seem to really support the idea of having keys listed other than id_dsa and id_rsa.

Some options:

* Modify sshutils and rbssh to properly use the .ssh/config.
* Modify the repository definition tables to allow a per-repository ssh key.
* Allow users to bypass rbssh to use the system ssh, which will honor the .ssh/config.

I'll be working on the first item for the moment.
#1 Phil.*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Posted a patch and a review request, http://reviews.reviewboard.org/r/2391/
david
#2 david
  • +Component-SSH
david
#3 david
  • +PendingReview