Quick Search

Review Request #2199 — Created March 14, 2011 and submitted — Latest diff uploaded


Review Board


Wrote an autocomplete wrapper in common.js. This quick search searches for users, groups and review requests. 
The autocomplete widget was modified to accommodate the feature where clicking on a suggestion would open the object's URL in a new window. 
The compressed version of the autocomplete widget is included.
Added the documentation for the search resource as well. I also removed ui.autocomplete in reviews.css to common.css. Added the js scripts that autocomplete needs in base.html and removed duplicate js files from other html templates. 
A lot of manual testing with as many different cases I could think of using different group display names & names, user username/first name/last name, and review request ID/summaries. Caught quite a few bugs through this. Not sure if this is all I should be doing. Am I suppose to be writing some tests as well?