Can you put this and the other resource-related doc changes into the resource change instead of this one?

Add a blank line in between these.

Why is this commented out? If it's temporary, please document the reason. If it's not needed anymore, please remove the block.

Add a line of ****s above the "User page hover" line.

Add spaces around the operator.

Add a space between // and the text, and capitalize "Only".

Don't add this line.

Space between if and (. Space between the // and comment, capitalize first word.

Space between the // and comment, capitalize first word.

Isn't this contained in your other review request?

Blank line between these.

Two blank lines between these.

Probably didn't mean to add this line.

The blank line on the comment should go away, and the last line should be "*/" not "* */"

Indentation should be 4 spaces. This looks like 8 or a tab. Make sure everything's using spaces only.

Brace should be on the same line as the if statement.

Same with the following if statements.

Also, you can just do data.username (same with the others)

Two blank lines between these.

Do you mean to override s each time? If so, please document each case, and make the ifs else ifs.

No spaces around data.

eval is too dangerous. I don't think you should need it anyway. My understanding was that data would be a javascript object anyway.

jsonData.search

Should be able to do:

var objects = ["users", "groups", "review_requests"];

Same.

Space before {

No parens around objects[j]

Space around the != operator.

{ on the same line as the if.

The values should be indented.

This comment should go inside the body.

else if (value.public) {

Indentation problems.

Trailing , will break things.

Also, "api/search/". No need to + things.

Not aligned. Make sure they're at the proper indentation level.

One line.

Indentation is wrong.

I don't know that clickURLChange is right now. The makeItem should be registering this. See below for some fixes that need to be made for makeItem though.

{ on the same line as the function.

At this point I'm not going to point them out. I suggest going through your change and making sure they're all correct. Same with the indentation changes.

One important thing: This file should never know how it's going to be used. This handler for makeItem should be overridable through options, just like some of the other functions, and the version for the search field should provide the implementation here.

The default implementation should do exactly what the old default implementation did.

data.summary

You should go through and fix all remaining occurrences.

Also, comment should be in the body.

One line.

Space before {

Comment should be in the body.

One line.

Space before {

Blank line between these.

You can just delete this entirely.

Delete all this. No point in overriding the block now.

The indentation is because some of it is using tabstops and some is using spaces. Make sure there are no tabstops in the code at all, and that all indentation is done via spaces.

Indent this the same as the other functions.

Can you fix the tabstops in this code?

This is no longer indented correctly.

Is datagrid.js really needed in the base template?

Okay, I just applied the patch to my tree and tried it out, and I have some usability comments:

The drop-down text currently has
    "Review Request Summary        (id)"

- If the summary is too long on any given review request, the text will overlap the (id) and will be ugly and impossible to read. We should make the drop-down for this box wider and give it a limit on the width of the text (overflow: clipped) so it never overlaps.
- There's a "Press tab to auto-complete" item, which works, but fills in the text of the search box with the summary. I'm not sure how useful that really is.
- If you hit enter after entering a review request number, even though you saw it in the drop-down, the search results will be empty. The request in bug 1842 (going directly to the review request) seems nice.

???????

Okay, one last user interaction niggle: When I type in the ID of a review request, the drop-down immediately focuses the single item, which means when I press "enter" on the keyboard, instead of searching for that ID, it fills the entry with the text of the drop-down. I'd prefer it if it didn't focus any items, so that unless I press the down arrow on the keyboard, it won't fill anything into the text box that I didn't type.

Pushed to master as d502a61. Thanks for all your hard work!