Process the install directory into sample config files




 


  Review Request #197
  —
  Created Dec. 16, 2007 and submitted

 















 
  
  
 




 
  

   Information

  

 
 

  

   
   
david


  


  

   
   
Review Board SVN (deprecated)


  


  

   
   
trunk


  


  

   
   



  


  

   
   



  


 



 
  

   Reviewers

  

 
 

  

   
   
reviewboard


  


  

   
   



  


 











 

  
  


We ship sample config files for lighttpd+fastcgi, apache+fastcgi and apache+mod_python.  One of the things that always bothered me about these is that they had the paths used by the various contributors of these configs.  Surprisingly, not everyone wants to install reviewboard into /root/reviewboard or /usr/share/reviewboard.

Since we've now got this great build system to install things with, we can make it so these configs have the right paths for everything, and just require people to fill in their host name and port.

There's more to do for this before everything is super sweet.
1. Verify that everything that needs to be installed is, actually, installed.
2. Make sure everything that we want to distribute is, actually, distributed.
3. Write init scripts for various linuxes (although maybe just sysvinit is OK, since I bet gentoo will write their own).
4. Build a virtual appliance.  Use this experience to make sure that there are a minimum of steps for a user.
5. Update the GettingStarted wiki page.
6. Write other docs, such as README, AUTHORS, etc.
7. 1.0




 




 

  
  


- Ran make install and checked resulting config files.
- Make distcheck




 














 

 














  

 








 














 





 

  

   




chipx86




   

   





  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Sweet. This generally looks good.

While we're in these files, there's a few things we should clean up.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    




    
    We might want to document this a little. Specifically talk about the port and timeout implications.
    
  
    
 
    

 
    
  



 
    

    3. 






  3. 
 
    
  
  
    
  
 

   
    
    
    




    
    Strip the trailing slash.
    
  
    
 
    

 
    
  



 
    

    4. 






  4. 
 
    
  
  
    
  
 

   
    
    
    




    
    Are these still needed with the aliases above? One or the other should be nuked.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I think it was temporary while I was trying to get things working.  Removed.
      
 
      

      2. 


 
    


    

 
    

    5. 






  5. 
 
    
  
  
    
  
 

   
    
    
    




    
    Should probably nuke these.
    
  
    
 
    

 
    
  



 
    

    6. 






  6. 
 
    
  
  
    
  
 

   
    
    
    




    
    This path is going to be wrong on anything not Python 2.4. Also, it doesn't match what we're doing in the other Apache file. What should /media be pointing to?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I've added some code to detect where the django installation is and use the correct path.  If django isn't installed at the time they do make install, it'll say /path/to/django/...
      
 
      

      2. 


 
    


    

 
    

    7. 






  7. 
 
    
  
  
    
  
 

   
    
    
    




    
    Trailing / on errordocs.
    
  
    
 
    

 
    
  



 
    

    8. 






  8. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      /trunk/reviewboard/contrib/conf/lighttpd.conf.in
      


       (Diff revision 3)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    




    
    Do we have any /errordocs here anywhere?
    
  
    
 
    

 
    
  



 
    

    9. 






  9. 
 
    
  
  
    
  
 

   
    
    
    




    
    Same comment about /media here.
    
  
    
 
    

 
    
  



 
    

    10. 




  10. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    11. 




  

 
















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Looks great. Ship it!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 









     

    

   

  

  

   
   Loading...