Use MEDIA_SERIAL on dashboard images.

Review Request #1896 — Created Nov. 7, 2010 and submitted

Information

Review Board
https://github.com/bhollis/reviewboard/tree/media_serial

Reviewers

This is similar to http://reviews.reviewboard.org/r/1887/ and makes sure that all images on the dashboard correctly include MEDIA_SERIAL, which not only makes them cache properly when served with far-future expires headers, but prevents the same images from being fetched twice on the same page with two different URLs.
Checked that all dashboard images now serve with a consistent URL that includes the MEDIA_SERIAL.
chipx86
  1. 
      
  2. reviewboard/reviews/datagrids.py (Diff revision 1)
     
     
    Can you make sure everything wraps to < 80 columns?
  3. 
      
BH
Review request changed

Change Summary:

Fixed so lines don't exceed 80 characters. I'll keep that in mind for future patches.

Diff:

Revision 2 (+13 -7)

Show changes

david
  1. Pushed to master as 38b4544. Thanks!
  2. 
      
Loading...