Summary

Use MEDIA_SERIAL on dashboard images.

Review Request #1896 — Created Nov. 7, 2010 and submitted

Information

Owner

bhollis

Repository

Review Board

Branch

https://github.com/bhollis/reviewboard/tree/media_serial

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This is similar to http://reviews.reviewboard.org/r/1887/ and makes sure that all images on the dashboard correctly include MEDIA_SERIAL, which not only makes them cache properly when served with far-future expires headers, but prevents the same images from being fetched twice on the same page with two different URLs.

Testing Done

Checked that all dashboard images now serve with a consistent URL that includes the MEDIA_SERIAL.

reviewboard/reviews/datagrids.py (Diff revision 1)

Can you make sure everything wraps to < 80 columns?

Change Summary:

Fixed so lines don't exceed 80 characters. I'll keep that in mind for future patches.

Diff:

Revision 2 (+13 -7)

Show changes

	reviewboard/reviews/datagrids.py
	reviewboard/reviews/templatetags/reviewtags.py

Ship it!

```
Pushed to master as 38b4544. Thanks!
```