Summary

Reviewboard Windows Installer

Review Request #1854 — Created Oct. 24, 2010 and discarded Sept. 24, 2011, 11:57 p.m.

Information

Owner

LailaAgaev

Repository

Win32 Installer

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Windows Installer for Reviewboard, made with NSIS:

Updates and improves the Windows Installer for ReviewBoard. Currently this installer will install:
* Python 2.6 (if it's not already installed)
* GNU Patch (if it's not already on the PATH)
* Python Setup Tools
* PyCrypto
* PIL
* Reviewboard + dependencies (via easy_install)

It also optionally installs Memcached, and various Python bindings for databases and/or source control systems. These features are still under development.

Currently the installer basically calls several distutils installers and several easy_install commandline windows. It's a bit of a mess, but it works. It's also not using Macros appropriately-- I will be making the code neater as I'm clearer on what else needs to be added. It is documented reasonably well as far as I see.

Testing Done

I've installed it on a very clean Windows XP 32 bit VM. I've also tried it on my (not at all clean) 32 bit XP to check that it detects Python and Patch. I've been able to set up a working Review Board installation using Bitnami's WAMP stack, a download of mod_python, this installer, rb-site and a few modifications to the Apache config files.

Screenshots

First installer page

In the future, to update an existing review request, use the -r parameter with the review request ID, so you won't have to create a new one and discard an old one.

Change Summary:

Updated the installer code-- it is now complete and should install a complete Review Board installation plus bindings for perforce, svn, MySQL, PostgreSQL, and memcached. To get Review Board working the user can do the following steps:

- go to http://bitnami.org/stacks and install one of the stacks with MySQL and Apache
- run our installer, choosing the matching database.
- get mod_python for python 2.5 and install that (copy a file and edit the apache config in a very obvious way)
- run rb-site, being careful to check what bitnami sets the port for MySQL (it's in their read-me, the stack I used was 1336)
- copy the generated config file to the appropriate place in the Apache installation. Then you need to edit the configuration permissions
  so Apache will allow Reviewboard to be visible to the user. By default our permissions and theirs don't match. This is the one step that is a touch confusing and might require documentation.

Diff:

Revision 2 (+539 -123)

Show changes

install.nsi

Laila:

First off, I've never worked with NSIS, so I'm really not qualified to comment on too much of the coding.  I can, however, make a few points/suggestions.

1)  Wherever possible, alphabetize long lists of unordered items.  I've highlighted an example below.
2)  Is it possible to constrict to 80 chars per line?  (Is that how we want to roll with this David / Christian?)
3)  Wherever possible, it's Review Board, as opposed to Reviewboard or ReviewBoard.
4)  There's some extraneous whitespace that can be chopped out.

I'm unable to test this, since I've been unable to borrow a Windows machine for the job.  Hopefully this week I'll get a chance to try it out.

Thanks for your work!

-Mike

install.nsi (Diff revision 2)

Review Board, as opposed to ReviewBoard, I think.

install.nsi (Diff revision 2)

Yep - I guess this'll need to be bumped each time a new version gets released.

This should probably be for 1.6?

install.nsi (Diff revision 2)

Should this be Review Board, or Beanbag Inc?

install.nsi (Diff revision 2)

should be http://www.reviewboard.org/

install.nsi (Diff revision 2)

This is an example of something you could alphabetize.

install.nsi (Diff revision 2)
```
There too, etc...
```
install.nsi (Diff revision 2)
```
Review Board
```
install.nsi (Diff revision 2)
```
ws
```
install.nsi (Diff revision 2)
```
ws
```
install.nsi (Diff revision 2)
```
ws
```
install.nsi (Diff revision 2)
```
ws
```
install.nsi (Diff revision 2)
```
ws - not going to mention the rest.
```

Laila:

Hey - I finally hopped onto a Windows machine and got to try this out.  ;)

Two notes - see below.  Thanks,

-Mike

install.nsi (Diff revision 2)

Hm - how's this going to work?  Are we going to ask the user where we're going to download Review Board to?

LailaAgaev Nov. 28, 2010, 1:42 a.m.

This is not for the user, this is for the person compiling the script to create an EXE file the user can run. This variable points to the location of the Review Board source of the person compiling it. I've changed it to be "../.." (a typical relative location of the reviewboard/reviewboard relative to reviewboard/rb-win32-installer dirs). Obviously if the user is able to download the Review Board source, they can create their own installer, but I thought the use case would run more along the lines of a developer compiling the installer and posting it online for users to download. Is this correct?

install.nsi (Diff revision 2)

For some reason, this fails for me - I get:

Installing Python Pytz module...
Pytz failed to install: error
An essential part of the installation, Pytz, failed to install.  Aborting installation.

Can't see why - from a DOS prompt, easy_install pytz runs just fine.

LailaAgaev Nov. 28, 2010, 1:38 a.m.

This was working for me, then suddenly stopped when I tested it after your review, then worked again... basically it's inconsistent. I did some research and apparently the PATH updating that I had trouble with before was still not working properly. Anyway it should work now. I've tested it 5-6 times on a clean VM and it seems to be stable.

Change Summary:

Updated in response to Mike Conley's review:

- whitespace removed
- fixed bug in PATH update function
- changed references to product name to "Review Board" and the version to 1.6
- added other minor changes that improve appearance/functionality

IMPORTANT:

I changed the way we handle pysvn: we no longer download their installer, instead we now package it (so to compile this .nsi file, 2 pysvn installers must be downloaded into the same folder as the .nsi. Instructions are on the first line of comments in the file). 
This is because on some systems Windows is unable to handle redirection during download and the download will fail.

Diff:

Revision 3 (+539 -123)

Show changes

install.nsi

Summary:: Reviewboard Windows Installer -- very eary draft
Reviewboard Windows Installer

Change Summary:: Updated testing done section.
Testing Done:: ~
I've installed it on a very clean Windows XP 32 bit VM. I've also tried it on my (not at all clean) 32 bit XP to check that it detects Python and Patch. I've yet to fully test a Reviewboard installation because Paramiko's download location has gone down and that means I can't complete the installation. I have been able to use rb-site to set up a reviewboard site without giving errors.
~
I've installed it on a very clean Windows XP 32 bit VM. I've also tried it on my (not at all clean) 32 bit XP to check that it detects Python and Patch. I've been able to set up a working Review Board installation using Bitnami's WAMP stack, a download of mod_python, this installer, rb-site and a few modifications to the Apache config files.

Status:: Discarded

~		I've installed it on a very clean Windows XP 32 bit VM. I've also tried it on my (not at all clean) 32 bit XP to check that it detects Python and Patch. I've yet to fully test a Reviewboard installation because Paramiko's download location has gone down and that means I can't complete the installation. I have been able to use rb-site to set up a reviewboard site without giving errors.
	~	I've installed it on a very clean Windows XP 32 bit VM. I've also tried it on my (not at all clean) 32 bit XP to check that it detects Python and Patch. I've been able to set up a working Review Board installation using Bitnami's WAMP stack, a download of mod_python, this installer, rb-site and a few modifications to the Apache config files.