• 
      

    Move RunTool task arguments and queue names into helper functions.

    Review Request #15545 — Created Nov. 17, 2026 and updated

    Information

    ReviewBot
    release-5.x

    Reviewers

    We had some repeat code in the automatic and manual RunTool invocation
    paths, which are about to get a bit more complicated. This change splits
    out the common parts into helper functions. One builds the queue name
    and the other builds the keyword arguments going into it.

    There's also a fix for a bad check on matching_configs, which
    attempted to bail early but failed due to matching_configs being a
    generator. Plus some typing improvements.

    Unit tests pass.

    Summary ID
    Move RunTool task arguments and queue names into helper functions.
    We had some repeat code in the automatic and manual `RunTool` invocation paths, which are about to get a bit more complicated. This change splits out the common parts into helper functions. One builds the queue name and the other builds the keyword arguments going into it. There's also a fix for a bad check on `matching_configs`, which attempted to bail early but failed due to `matching_configs` being a generator. Plus some typing improvements.
    844bf35d42fa7f19656f24a488be0bbf44124770
    Description From Last Updated

    'reviewbotext.extension.ReviewBotExtension' imported but unused Column: 1 Error code: F401

    reviewbot reviewbot
    Checks run (1 failed, 1 succeeded)
    flake8 failed.
    JSHint passed.

    flake8

    chipx86
    Review request changed
    Change Summary:

    Removed an unused import.

    Commits:
    Summary ID
    Move RunTool task arguments and queue names into helper functions.
    We had some repeat code in the automatic and manual `RunTool` invocation paths, which are about to get a bit more complicated. This change splits out the common parts into helper functions. One builds the queue name and the other builds the keyword arguments going into it. There's also a fix for a bad check on `matching_configs`, which attempted to bail early but failed due to `matching_configs` being a generator. Plus some typing improvements.
    42efa97d7e779d192febe1f4aff153c0047448b5
    Move RunTool task arguments and queue names into helper functions.
    We had some repeat code in the automatic and manual `RunTool` invocation paths, which are about to get a bit more complicated. This change splits out the common parts into helper functions. One builds the queue name and the other builds the keyword arguments going into it. There's also a fix for a bad check on `matching_configs`, which attempted to bail early but failed due to `matching_configs` being a generator. Plus some typing improvements.
    844bf35d42fa7f19656f24a488be0bbf44124770

    Checks run (2 succeeded)

    flake8 passed.
    JSHint passed.