• 
      

    Fix sending Review Bot tasks when a tool is missing.

    Review Request #15544 — Created Nov. 17, 2026 and updated

    Information

    ReviewBot
    release-5.x

    Reviewers

    When going through the configurations before sending a RunTool task,
    it was possible for a configuration to specify a Tool that no longer
    exists. If this happened, we'd correctly log it as missing, but fail to
    actually skip it, instead using the previously-fetched Tool or just
    outright failing if the variable wasn't yet set.

    We now skip the configuration correctly, and also protect against any
    weirdness with the tool ID we log by just using %s instead of %d.

    Unit tests pass.

    Summary ID
    Fix sending Review Bot tasks when a tool is missing.
    When going through the configurations before sending a `RunTool` task, it was possible for a configuration to specify a `Tool` that no longer exists. If this happened, we'd correctly log it as missing, but fail to actually skip it, instead using the previously-fetched `Tool` or just outright failing if the variable wasn't yet set. We now skip the configuration correctly, and also protect against any weirdness with the tool ID we log by just using `%s` instead of `%d`.
    e199a15929c1a8d8d59c3dbff7058f057fccf756
    Checks run (2 succeeded)
    flake8 passed.
    JSHint passed.