Summary

Search: Add faceted search view routing and templates

Review Request #15054 — Created May 13, 2026 and updated May 15, 2026, 4:38 p.m.

Information

Owner

dan.casares

Repository

Review Board

Branch

release-8.x

Bugs

Depends On

15051, 15052, 15053

Reviewers

Groups

reviewboard

People

Description

Updates RBSearchView and adds the templates and CSS for the new faceted
search results page.

RBSearchView.dispatch now checks whether the active backend exposes
get_es_client. If it does, a FacetedSearchEngine is constructed and
_use_faceted is set to True. Any exception during construction falls back
silently to the existing Haystack path. Numeric queries still redirect directly
to the matching review request when accessible.

get_template_names returns search/results.html for the faceted path and
search/results_legacy.html for the Haystack path.

get_context_data on the faceted path calls FacetedSearchEngine.search,
builds the group sidebar items with total counts, resolves human-readable
labels for searchable filter buckets (reviewer, group, repository), and
assembles the filter panel context including current values, bucket lists, and
option counts.

results.html is the new template for the faceted path, providing the filter
sidebar and results list. results_legacy.html is the existing template
renamed, unchanged in behaviour.

search.less adds styles for the filter sidebar, bucket counts, active filter
indicators, and the Contents filter checkbox group.

_comment.html and _group.html are new partial templates for rendering
comment and group search results inline.

Testing Done

Verified that dispatch correctly routes to the faceted path when
Elasticsearch is available and falls back silently to the Haystack path when it
is not or when engine construction fails. Verified template selection, user
attachment on search hits, numeric query redirection, and Whoosh wildcard
rewriting. Confirmed the existing Haystack path is unaffected.

Commits

Summary	ID	Author
Search: Add faceted search view routing and templates	bdeb43497a0aca208a555832cbf3bd415624d722	DanielCasaresIglesias

Issues

Description	From	Last Updated
'django.contrib.auth.models.User' imported but unused Column: 1 Error code: F401	reviewbot	May 15, 2026, 4:22 p.m.
'django.urls.reverse' imported but unused Column: 1 Error code: F401	reviewbot	May 15, 2026, 4:22 p.m.
line too long (138 > 79 characters) Column: 80 Error code: E501	reviewbot	May 15, 2026, 4:22 p.m.
continuation line under-indented for visual indent Column: 27 Error code: E128	reviewbot	May 15, 2026, 4:22 p.m.
line too long (82 > 79 characters) Column: 80 Error code: E501	reviewbot	May 15, 2026, 4:22 p.m.
line too long (138 > 79 characters) Column: 80 Error code: E501	reviewbot	May 15, 2026, 4:22 p.m.
continuation line under-indented for visual indent Column: 27 Error code: E128	reviewbot	May 15, 2026, 4:22 p.m.
redefinition of unused 'User' from line 21 Column: 9 Error code: F811	reviewbot	May 15, 2026, 4:22 p.m.
line too long (81 > 79 characters) Column: 80 Error code: E501	reviewbot	May 15, 2026, 4:22 p.m.
local variable 'parts' is assigned to but never used Column: 9 Error code: F841	reviewbot	May 15, 2026, 4:22 p.m.
line too long (81 > 79 characters) Column: 80 Error code: E501	reviewbot	May 15, 2026, 4:22 p.m.
line break before binary operator Column: 21 Error code: W503	reviewbot	May 15, 2026, 4:22 p.m.
'haystack.query.EmptySearchQuerySet' imported but unused Column: 1 Error code: F401	reviewbot	May 15, 2026, 4:22 p.m.
multiple spaces before keyword Column: 34 Error code: E272	reviewbot	May 15, 2026, 4:22 p.m.
continuation line unaligned for hanging indent Column: 21 Error code: E131	reviewbot	May 15, 2026, 4:35 p.m.
continuation line unaligned for hanging indent Column: 21 Error code: E131	reviewbot	May 15, 2026, 4:35 p.m.
line break before binary operator Column: 21 Error code: W503	reviewbot	May 15, 2026, 4:38 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/search/tests/test_search_view_faceted.py (Diff revision 1)
The issue has been dropped. Show all issues
```
'django.contrib.auth.models.User' imported but unused

Column: 1
Error code: F401
```
reviewboard/search/tests/test_search_view_faceted.py (Diff revision 1)
The issue has been dropped. Show all issues
```
'django.urls.reverse' imported but unused

Column: 1
Error code: F401
```
reviewboard/search/tests/test_search_view_faceted.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (138 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/search/tests/test_search_view_faceted.py (Diff revision 1)
The issue has been dropped. Show all issues
```
continuation line under-indented for visual indent

Column: 27
Error code: E128
```
reviewboard/search/tests/test_search_view_faceted.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (82 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/search/tests/test_search_view_faceted.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (138 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/search/tests/test_search_view_faceted.py (Diff revision 1)
The issue has been dropped. Show all issues
```
continuation line under-indented for visual indent

Column: 27
Error code: E128
```
reviewboard/search/tests/test_search_view_faceted.py (Diff revision 1)
The issue has been dropped. Show all issues
```
redefinition of unused 'User' from line 21

Column: 9
Error code: F811
```
reviewboard/search/tests/test_search_view_faceted.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (81 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/search/tests/test_search_view_faceted.py (Diff revision 1)
The issue has been dropped. Show all issues
```
local variable 'parts' is assigned to but never used

Column: 9
Error code: F841
```
reviewboard/search/tests/test_search_view_faceted.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (81 > 79 characters)

Column: 80
Error code: E501
```
reviewboard/search/tests/test_search_view_faceted.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 21
Error code: W503
```

reviewboard/search/views.py (Diff revision 1)

The issue has been dropped. Show all issues

'haystack.query.EmptySearchQuerySet' imported but unused

Column: 1
Error code: F401

reviewboard/search/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
multiple spaces before keyword

Column: 34
Error code: E272
```

Commits:

	Summary	ID	Author
	Search: Add faceted search view routing and templates	407e9e37a703f4ae0878fc5ce4ab865cd41f92f3	DanielCasaresIglesias
	Search: Add faceted search view routing and templates	9b9ccd0c68798fc5b86004152ef7f80455032c62	DanielCasaresIglesias

Diff:

Revision 2 (+4492 -332)

Show changes

	reviewboard/search/views.py
	reviewboard/search/tests/test_search_view_faceted.py
	reviewboard/static/rb/css/pages/search.less
	reviewboard/templates/search/_comment.html
	reviewboard/templates/search/_group.html
	reviewboard/templates/search/results.html
	reviewboard/templates/search/results_legacy.html

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/search/tests/test_search_view_faceted.py (Diff revision 2)
The issue has been dropped. Show all issues
```
continuation line unaligned for hanging indent

Column: 21
Error code: E131
```
reviewboard/search/tests/test_search_view_faceted.py (Diff revision 2)
The issue has been dropped. Show all issues
```
continuation line unaligned for hanging indent

Column: 21
Error code: E131
```

Commits:

	Summary	ID	Author
	Search: Add faceted search view routing and templates	9b9ccd0c68798fc5b86004152ef7f80455032c62	DanielCasaresIglesias
	Search: Add faceted search view routing and templates	0de4195f9a7315e369db6bcf7a527a92ecb2c77c	DanielCasaresIglesias

Diff:

Revision 3 (+4496 -332)

Show changes

	reviewboard/search/views.py
	reviewboard/search/tests/test_search_view_faceted.py
	reviewboard/static/rb/css/pages/search.less
	reviewboard/templates/search/_comment.html
	reviewboard/templates/search/_group.html
	reviewboard/templates/search/results.html
	reviewboard/templates/search/results_legacy.html

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/search/tests/test_search_view_faceted.py (Diff revision 3)
The issue has been dropped. Show all issues
```
line break before binary operator

Column: 21
Error code: W503
```

Commits:

	Summary	ID	Author
	Search: Add faceted search view routing and templates	0de4195f9a7315e369db6bcf7a527a92ecb2c77c	DanielCasaresIglesias
	Search: Add faceted search view routing and templates	bdeb43497a0aca208a555832cbf3bd415624d722	DanielCasaresIglesias

Diff:

Revision 4 (+4496 -332)

Show changes

	reviewboard/search/views.py
	reviewboard/search/tests/test_search_view_faceted.py
	reviewboard/static/rb/css/pages/search.less
	reviewboard/templates/search/_comment.html
	reviewboard/templates/search/_group.html
	reviewboard/templates/search/results.html
	reviewboard/templates/search/results_legacy.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.