Summary

Speed up user search indexing by fixing query cache usage for profiles.

Review Request #15013 — Created April 15, 2026 and submitted April 28, 2026, 9:52 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Blocks

15014

Reviewers

Groups

reviewboard

People

Description

User.get_profile() has checks in place to make use of any profile

fetched along with the user via select_related() or

prefetch_related().
In the case where the cached profile result is a None, we were falling

back on default behavior based on the create_if_missing flag. This is

fine if the flag is True (we want to create) but if the flag is

False a redundant fetch would occur, which would likely still return a

None result.
This code now respects a None entry in the cache in this case, which

will raise Profile.DoesNotExist as it would have before, but without

the redundant database query.
This will significantly speed up search indexing for users, which was

performing 4 queries per user.

Testing Done

Unit tests pass.

Built new unit tests (for an upcoming change) that found this issue and
verified the fix.

Commits

Summary	ID
Speed up user search indexing by fixing query cache usage for profiles. `User.get_profile()` has checks in place to make use of any profile fetched along with the user via `select_related()` or `prefetch_related()`. In the case where the cached profile result is a `None`, we were falling back on default behavior based on the `create_if_missing` flag. This is fine if the flag is `True` (we want to create) but if the flag is `False` a redundant fetch would occur, which would likely still return a `None` result. This code now respects a `None` entry in the cache in this case, which will raise `Profile.DoesNotExist` as it would have before, but without the redundant database query. This will significantly speed up search indexing for users, which was performing 4 queries per user.	0d8312240a2242ecc0271ca0a0d8f2e432242e57

Summary

Speed up user search indexing by fixing query cache usage for profiles.

`User.get_profile()` has checks in place to make use of any profile fetched along with the user via `select_related()` or `prefetch_related()`. In the case where the cached profile result is a `None`, we were falling back on default behavior based on the `create_if_missing` flag. This is fine if the flag is `True` (we want to create) but if the flag is `False` a redundant fetch would occur, which would likely still return a `None` result. This code now respects a `None` entry in the cache in this case, which will raise `Profile.DoesNotExist` as it would have before, but without the redundant database query. This will significantly speed up search indexing for users, which was performing 4 queries per user.

0d8312240a2242ecc0271ca0a0d8f2e432242e57

Issues

Description	From	Last Updated
This method now returns None if we've done select_related('profile') and the profile doesn't exist (where previously it would raise DoesNotExist. …	david	April 19, 2026, 6:58 a.m.
This should be updated to say that we explicitly do not fetch if the cache variable was already set to …	david	April 19, 2026, 7:01 a.m.
local variable 'profile' is assigned to but never used Column: 13 Error code: F841	reviewbot	April 19, 2026, 7:12 a.m.
Can we add num_statements to this?	david	April 28, 2026, 9:20 p.m.
Can we add num_statements to this?	david	April 28, 2026, 9:20 p.m.
Can we add num_statements to this?	david	April 28, 2026, 9:20 p.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/accounts/models.py (Diff revision 1)

The issue has been resolved. Show all issues

This method now returns None if we've done select_related('profile') and the profile doesn't exist (where previously it would raise DoesNotExist. It would be nice to clarify that here. as well as add a "Version Changed" block.

chipx86

April 19, 2026, 7:11 a.m.

I'll just restore this to raise a DoesNotExist again. The main thing is to avoid an unnecessary query.

reviewboard/accounts/models.py (Diff revision 1)

The issue has been resolved. Show all issues

This should be updated to say that we explicitly do not fetch if the cache variable was already set to None

Change Summary:


Restored the Profile.DoesNotExist error.
Clarified the conditions in a comment.

Description:

		`User.get_profile()` has checks in place to make use of any profile
		fetched along with the user via `select_related()` or
		`prefetch_related()`.

		In the case where the cached profile result is a `None`, we were falling
		back on default behavior based on the `create_if_missing` flag. This is
		fine if the flag is `True` (we want to create) but if the flag is
		`False` a redundant fetch would occur, which would likely still return a
		`None` result.

~		This code now respects a `None` entry in the cache in this case,
~		returning the `None` directly without the extra fetch.
	~	This code now respects a `None` entry in the cache in this case, which
	~	will raise `Profile.DoesNotExist` as it would have before, but without
	+	the redundant database query.

		This will significantly speed up search indexing for users, which was
		performing 4 queries per user.

Commits:

	Summary	ID
	Speed up user search indexing by fixing query cache usage for profiles. `User.get_profile()` has checks in place to make use of any profile fetched along with the user via `select_related()` or `prefetch_related()`. In the case where the cached profile result is a `None`, we were falling back on default behavior based on the `create_if_missing` flag. This is fine if the flag is `True` (we want to create) but if the flag is `False` a redundant fetch would occur, which would likely still return a `None` result. This code now respects a `None` entry in the cache in this case, returning the `None` directly without the extra fetch. This will significantly speed up search indexing for users, which was performing 4 queries per user.	a811778bca289d5549c5ab3e0db679d6212b4ef7
	Speed up user search indexing by fixing query cache usage for profiles. `User.get_profile()` has checks in place to make use of any profile fetched along with the user via `select_related()` or `prefetch_related()`. In the case where the cached profile result is a `None`, we were falling back on default behavior based on the `create_if_missing` flag. This is fine if the flag is `True` (we want to create) but if the flag is `False` a redundant fetch would occur, which would likely still return a `None` result. This code now respects a `None` entry in the cache in this case, which will raise `Profile.DoesNotExist` as it would have before, but without the redundant database query. This will significantly speed up search indexing for users, which was performing 4 queries per user.	42bd585f0143ac18e69067bf74afa9d16f988729

Diff:

Revision 2 (+182 -12)

Show changes

	reviewboard/accounts/models.py
	reviewboard/accounts/tests/test_user.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/accounts/tests/test_user.py (Diff revision 2)
The issue has been resolved. Show all issues
```
local variable 'profile' is assigned to but never used

Column: 13
Error code: F841
```

Change Summary:

Removed an unused variable.

Commits:

	Summary	ID
	Speed up user search indexing by fixing query cache usage for profiles. `User.get_profile()` has checks in place to make use of any profile fetched along with the user via `select_related()` or `prefetch_related()`. In the case where the cached profile result is a `None`, we were falling back on default behavior based on the `create_if_missing` flag. This is fine if the flag is `True` (we want to create) but if the flag is `False` a redundant fetch would occur, which would likely still return a `None` result. This code now respects a `None` entry in the cache in this case, which will raise `Profile.DoesNotExist` as it would have before, but without the redundant database query. This will significantly speed up search indexing for users, which was performing 4 queries per user.	42bd585f0143ac18e69067bf74afa9d16f988729
	Speed up user search indexing by fixing query cache usage for profiles. `User.get_profile()` has checks in place to make use of any profile fetched along with the user via `select_related()` or `prefetch_related()`. In the case where the cached profile result is a `None`, we were falling back on default behavior based on the `create_if_missing` flag. This is fine if the flag is `True` (we want to create) but if the flag is `False` a redundant fetch would occur, which would likely still return a `None` result. This code now respects a `None` entry in the cache in this case, which will raise `Profile.DoesNotExist` as it would have before, but without the redundant database query. This will significantly speed up search indexing for users, which was performing 4 queries per user.	0d8312240a2242ecc0271ca0a0d8f2e432242e57

Diff:

Revision 3 (+182 -12)

Show changes

	reviewboard/accounts/models.py
	reviewboard/accounts/tests/test_user.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/accounts/tests/test_user.py (Diff revision 3)

The issue has been dropped. Show all issues

Can we add num_statements to this?

chipx86

April 28, 2026, 9:20 p.m.

num_statements is legacy and no longer used by django-assert-queries in any capacity. It was a holdover from older versions of the support in Djblets.

reviewboard/accounts/tests/test_user.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Can we add num_statements to this?
```
reviewboard/accounts/tests/test_user.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Can we add num_statements to this?
```

Status:: Completed
Change Summary:: Pushed to release-8.x (cb548c3)