chipx86 got a fish trophy!

Summary

Add Certificate.create_from_server().

Review Request #14941 — Created March 18, 2026 and submitted April 20, 2026, 2:10 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

~~14940~~

Reviewers

Groups

reviewboard

People

Description

This method constructs a Certificate instance from a server,
containing the hostname, port, and certificate data. This can be used
to retrieve state from a certificate when encountering an SSL error,
which does not itself represent certificate information.

No validation on the certificate itself will be performed (aside from
attempting to load the content). It's the caller's responsibility to
process the certificate in whichever way it needs.

Testing Done

Unit tests pass.
Used this in the upcoming SSL error class work.

Commits

Summary	ID
Add Certificate.create_from_server(). This method constructs a `Certificate` instance from a server, containing the hostname, port, and certificate data. This can be used to retrieve state from a certificate when encountering an SSL error, which does not itself represent certificate information. No validation on the certificate itself will be performed (aside from attempting to load the content). It's the caller's responsibility to process the certificate in whichever way it needs.	8b7b085dcb5af3192b59d0fd6cb5bf715186a513

Summary

Add Certificate.create_from_server().

This method constructs a `Certificate` instance from a server, containing the hostname, port, and certificate data. This can be used to retrieve state from a certificate when encountering an SSL error, which does not itself represent certificate information. No validation on the certificate itself will be performed (aside from attempting to load the content). It's the caller's responsibility to process the certificate in whichever way it needs.

8b7b085dcb5af3192b59d0fd6cb5bf715186a513

Issues

Description	From	Last Updated
While this is caught just below, perhaps ValueError is more appropriate.	david	April 2, 2026, 2:29 p.m.
This doesn't fix the problem with it being macos-specific ([Errno 8] nodename nor servname provided, or not known). On Linux …	david	April 8, 2026, 1:32 a.m.
This exact error message is macos specific.	david	April 2, 2026, 2:29 p.m.

flake8 passed.

JSHint passed.

reviewboard/certs/cert.py (Diff revision 1)
The issue has been resolved. Show all issues
```
While this is caught just below, perhaps ValueError is more appropriate.
```
reviewboard/certs/tests/test_certificate.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This exact error message is macos specific.
```
1. chipx86
  
  April 2, 2026, 2:34 p.m.
  Good catch.

Change Summary:


Switched to a ValueError.
Switched a unit test to test for the beginning of a string instead of the macOS-specific error.

Commits:

	Summary	ID
	Add Certificate.create_from_server(). This method constructs a `Certificate` instance from a server, containing the hostname, port, and certificate data. This can be used to retrieve state from a certificate when encountering an SSL error, which does not itself represent certificate information. No validation on the certificate itself will be performed (aside from attempting to load the content). It's the caller's responsibility to process the certificate in whichever way it needs.	9dff5bd2d750d2a88e4c99f16933cd74caa2e1c3
	Add Certificate.create_from_server(). This method constructs a `Certificate` instance from a server, containing the hostname, port, and certificate data. This can be used to retrieve state from a certificate when encountering an SSL error, which does not itself represent certificate information. No validation on the certificate itself will be performed (aside from attempting to load the content). It's the caller's responsibility to process the certificate in whichever way it needs.	dfacdd559e3930914c1f28dfdc3f701a1533b3ec

Diff:

Revision 2 (+214)

Show changes

	reviewboard/certs/cert.py
	reviewboard/certs/tests/test_certificate.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/certs/tests/test_certificate.py (Diff revisions 1 - 2)

The issue has been resolved. Show all issues

This doesn't fix the problem with it being macos-specific ([Errno 8] nodename nor servname provided, or not known). On Linux the error looks more like [Errno -2] Name or service not known.

chipx86

April 8, 2026, 1:31 a.m.
```
I just completely screwed that up.
```

Change Summary:

Actually hopefully fixed the platform-specific string check.

Commits:

	Summary	ID
	Add Certificate.create_from_server(). This method constructs a `Certificate` instance from a server, containing the hostname, port, and certificate data. This can be used to retrieve state from a certificate when encountering an SSL error, which does not itself represent certificate information. No validation on the certificate itself will be performed (aside from attempting to load the content). It's the caller's responsibility to process the certificate in whichever way it needs.	dfacdd559e3930914c1f28dfdc3f701a1533b3ec
	Add Certificate.create_from_server(). This method constructs a `Certificate` instance from a server, containing the hostname, port, and certificate data. This can be used to retrieve state from a certificate when encountering an SSL error, which does not itself represent certificate information. No validation on the certificate itself will be performed (aside from attempting to load the content). It's the caller's responsibility to process the certificate in whichever way it needs.	8b7b085dcb5af3192b59d0fd6cb5bf715186a513

Diff:

Revision 3 (+212)

Show changes

	reviewboard/certs/cert.py
	reviewboard/certs/tests/test_certificate.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-8.x (9d56033)