Summary

Fix no-ops with the @online_only unit test decorator.

Review Request #14940 — Created March 18, 2026 and submitted April 8, 2026, 1:12 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

Blocks

14941

Reviewers

Groups

reviewboard

People

Description

In 2021, the @online_only decorator was rewritten to use

@simple_decorator, but the result was a function that performed no-ops

when online. Instead of calling the test function with the provided

arguments, it just returned the first argument as-is (which was the

self argument to the unit test class). This got ignored, resulting in

nothing happening when the test was run.
This did unveil that one test (Mercurial's HTTPS tests) were no longer

passing. This was due to the repository having bot protection deployed,

which meant we were getting HTTP 200 results that weren't actually the

file contents. We've switched to Mozilla's HG server for our test, which

currently has no bot protection.

Testing Done

Unit tests pass.

Commits

Summary	ID
Fix no-ops with the @online_only unit test decorator. In 2021, the `@online_only` decorator was rewritten to use `@simple_decorator`, but the result was a function that performed no-ops when online. Instead of calling the test function with the provided arguments, it just returned the first argument as-is (which was the `self` argument to the unit test class). This got ignored, resulting in nothing happening when the test was run. This did unveil that one test (Mercurial's HTTPS tests) were no longer passing. This was due to the repository having bot protection deployed, which meant we were getting HTTP 200 results that weren't actually the file contents. We've switched to Mozilla's HG server for our test, which currently has no bot protection.	54a4efab49603787b2a46fabd42bb07bf5dfb35f

Summary

Fix no-ops with the @online_only unit test decorator.

In 2021, the `@online_only` decorator was rewritten to use `@simple_decorator`, but the result was a function that performed no-ops when online. Instead of calling the test function with the provided arguments, it just returned the first argument as-is (which was the `self` argument to the unit test class). This got ignored, resulting in nothing happening when the test was run. This did unveil that one test (Mercurial's HTTPS tests) were no longer passing. This was due to the repository having bot protection deployed, which meant we were getting HTTP 200 results that weren't actually the file contents. We've switched to Mozilla's HG server for our test, which currently has no bot protection.

54a4efab49603787b2a46fabd42bb07bf5dfb35f

Issues

Description	From	Last Updated
It seems like this should just be return test_func	david	April 2, 2026, 2:19 p.m.

flake8 passed.

JSHint passed.

reviewboard/testing/__init__.py (Diff revision 1)

The issue has been dropped. Show all issues

It seems like this should just be return test_func

chipx86

April 2, 2026, 2:19 p.m.

They're different function types. The decorator needs to return a plain function, and we need to call a bound method. Otherwise you get:

INTERNALERROR>   File "/Users/chipx86/buildroots/rb7/lib/python3.12/site-packages/_pytest/compat.py", line 244, in get_real_func
INTERNALERROR>     raise ValueError(
INTERNALERROR> ValueError: could not find real function of <bound method MercurialTests.test_https_repo of <reviewboard.scmtools.tests.test_hg.MercurialTests testMethod=test_https_repo>>
INTERNALERROR> stopped at <function MercurialTests.test_https_repo at 0x124376340>

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (87827fb)