• 
      
    Fish Trophy

    chipx86 got a fish trophy!

    Fish Trophy

    Add Certificate.create_from_server().

    Review Request #14941 — Created March 18, 2026 and updated

    Information

    Review Board
    release-7.1.x

    Reviewers

    This method constructs a Certificate instance from a server,
    containing the hostname, port, and certificate data. This can be used
    to retrieve state from a certificate when encountering an SSL error,
    which does not itself represent certificate information.

    No validation on the certificate itself will be performed (aside from
    attempting to load the content). It's the caller's responsibility to
    process the certificate in whichever way it needs.

    Unit tests pass.

    Used this in the upcoming SSL error class work.

    Summary ID
    Add Certificate.create_from_server().
    This method constructs a `Certificate` instance from a server, containing the hostname, port, and certificate data. This can be used to retrieve state from a certificate when encountering an SSL error, which does not itself represent certificate information. No validation on the certificate itself will be performed (aside from attempting to load the content). It's the caller's responsibility to process the certificate in whichever way it needs.
    9dff5bd2d750d2a88e4c99f16933cd74caa2e1c3
    Description From Last Updated

    While this is caught just below, perhaps ValueError is more appropriate.

    daviddavid

    This exact error message is macos specific.

    daviddavid
    Checks run (2 succeeded)
    flake8 passed.
    JSHint passed.
    david
    1. 
        
    2. reviewboard/certs/cert.py (Diff revision 1)
       
       
      Show all issues

      While this is caught just below, perhaps ValueError is more appropriate.

    3. reviewboard/certs/tests/test_certificate.py (Diff revision 1)
       
       
       
       
      Show all issues

      This exact error message is macos specific.

    4.