SVN hook can include empty arguments which seems to confuse svn diff

Review Request #1440 — Created Feb. 28, 2010 and submitted — Latest diff uploaded

stodge
Review Board
1515
reviewboard
./rb-post-commit-hook /srv/svn/fred 11
/usr/bin/post-review --repository-url=file:///srv/svn/fred --
username=admin --password=admin -p --submit-as=mike --revision-
range=10:11   --server=http://localhost/reviews/fred --summary="refs
#1 - publish review" --description="(In [11]) refs #1 - publish
review"
Failed to execute command: ['/usr/bin/post-review', '--repository-
url=file:///srv/svn/fred', '--username=admin', '--password=admin', '-
p', '--submit-as=mike', '--revision-range=10:11', '', '', '--
server=http://localhost/reviews/fred' '--summary="refs #1 - publish
review"', '--description="(In [11]) refs #1 - publish review"', '']
Failed to execute command: ['svn', 'diff', '--diff-cmd=diff', 'file:///
srv/svn/fred/@10', 'file:///srv/svn/fred/@11', '', '', '']
['svn: Target lists to diff may not contain both working copy paths
and URLs\n']


The SVN hook can sometimes include empty arguments. Empty arguments should
be filtered from the argument list.
Tested locally to ensure there are no empty arguments.
Loading...