Summary

Avoid fetching a StatusUpdate per Review on the review request page.

Review Request #14313 — Created Jan. 29, 2025 and submitted March 20, 2025, 2:25 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.1.x

Bugs

Depends On

~~14314~~, ~~14312~~

Blocks

14316

Reviewers

Groups

reviewboard

People

Description

We had code in the review request page that checked for the presence of
the Review.status_update attribute. This in turn triggered a query for
the object on the other end of that relation, regardless of whether it
existed. That led to a useless query per review, especially since we had
already fetched all status updates on the page.

This change adds some pre-processing, creating a map of reviews to
status updates, and utilizes that map instead of performing the
attribute check.

This offers a pretty large savings on most review requests.

Testing Done

Unit tests passed.

Verified in Django Debug Toolbar that the repeated SQL queries for
status updates were no longer present.

Commits

Summary	ID
Avoid fetching a StatusUpdate per Review on the review request page. We had code in the review request page that checked for the presence of the `Review.status_update` attribute. This in turn triggered a query for the object on the other end of that relation, regardless of whether it existed. That led to a useless query per review, especially since we had already fetched all status updates on the page. This change adds some pre-processing, creating a map of reviews to status updates, and utilizes that map instead of performing the attribute check. This offers a pretty large savings on most review requests.	9510e1c617706e9c3a0362a8c289fa469e3c75a8

Summary

Avoid fetching a StatusUpdate per Review on the review request page.

We had code in the review request page that checked for the presence of the `Review.status_update` attribute. This in turn triggered a query for the object on the other end of that relation, regardless of whether it existed. That led to a useless query per review, especially since we had already fetched all status updates on the page. This change adds some pre-processing, creating a map of reviews to status updates, and utilizes that map instead of performing the attribute check. This offers a pretty large savings on most review requests.

9510e1c617706e9c3a0362a8c289fa469e3c75a8

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Change Summary:

Updated the new review request view unit tests.

Commits:

	Summary	ID
	Avoid fetching a StatusUpdate per Review on the review request page. We had code in the review request page that checked for the presence of the `Review.status_update` attribute. This in turn triggered a query for the object on the other end of that relation, regardless of whether it existed. That led to a useless query per review, especially since we had already fetched all status updates on the page. This change adds some pre-processing, creating a map of reviews to status updates, and utilizes that map instead of performing the attribute check. This offers a pretty large savings on most review requests.	3a83a7d013d82c2bacd6cb077276162f1d7afba1
	Avoid fetching a StatusUpdate per Review on the review request page. We had code in the review request page that checked for the presence of the `Review.status_update` attribute. This in turn triggered a query for the object on the other end of that relation, regardless of whether it existed. That led to a useless query per review, especially since we had already fetched all status updates on the page. This change adds some pre-processing, creating a map of reviews to status updates, and utilizes that map instead of performing the attribute check. This offers a pretty large savings on most review requests.	9510e1c617706e9c3a0362a8c289fa469e3c75a8

Depends On:

~~14314 - Add unit tests for the review request view.~~

Diff:

Revision 2 (+40 -124)

Show changes

	reviewboard/reviews/detail.py
	reviewboard/reviews/tests/test_review_request_detail_view.py
	reviewboard/reviews/tests/test_review_request_page_data.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.1.x (389906d)