Add expected query assertions for the ReviewRequestPageData tests.
Review Request #14312 — Created Jan. 29, 2025 and updated
In preparation for optimization work on
ReviewRequestPageData
, this
change fleshes out the current test suite with query assertion checks,
and adds some new tests and testing functionality.Review requests bound to repositories now use hosting services, which
ensures a bit more test coverage (and unveils issues surrounding
re-querying of repositories and other objects).This will give us a good foundation for seeing some of the effects of
upcoming optimizations.
Unit tests pass.
Summary | ID |
---|---|
01588a844db5fb0e7c8c18cc857c70811638fdf7 |
- Change Summary:
-
Updated repository-bound review requests in the tests to use hosting services, catching additional query issues.
- Description:
-
In preparation for optimization work on
ReviewRequestPageData
, thischange fleshes out the current test suite with query assertion checks, ~ and adds some new tests and testing functionality. This will give us a ~ good foundation for seeing some of the effects of upcoming ~ optimizations. ~ and adds some new tests and testing functionality. ~ ~ Review requests bound to repositories now use hosting services, which
+ ensures a bit more test coverage (and unveils issues surrounding + re-querying of repositories and other objects). + + This will give us a good foundation for seeing some of the effects of
+ upcoming optimizations. - Commits:
-
Summary ID b9ecb8e8a944cd359333de8ea234da1027c0827a 01588a844db5fb0e7c8c18cc857c70811638fdf7 - Diff:
-
Revision 2 (+4192 -372)