Add unit tests for the review request view.

Review Request #14314 — Created Jan. 30, 2025 and updated

Information

Review Board
release-7.1.x

Reviewers

A recent change introduced unit tests for ReviewRequestPageData, which
backs the review request page. This change fleshes out our testing
further, adding tests for the view, which encompasses all the stages of
ReviewRequestPageData along with other page components (actions,
JavaScript setup, etc.).

Review requests bound to repositories now use hosting services, which
ensures a bit more test coverage (and unveils issues surrounding
re-querying of repositories and other objects).

This gives a more comprehensive view of where database queries need to
be optimized.

Unit tests pass.

Summary ID
Add unit tests for the review request view.
A recent change introduced unit tests for `ReviewRequestPageData`, which backs the review request page. This change fleshes out our testing further, adding tests for the view, which encompasses all the stages of `ReviewRequestPageData` along with other page components (actions, JavaScript setup, etc.). Review requests bound to repositories now use hosting services, which ensures a bit more test coverage (and unveils issues surrounding re-querying of repositories and other objects). This gives a more comprehensive view of where database queries need to be optimized.
4c8d997525241e245c3069724036c9f4e4d4bdf7
chipx86
Review request changed
Change Summary:

Repository-backed review requests in the tests now use hosting services.

Description:
   

A recent change introduced unit tests for ReviewRequestPageData, which

    backs the review request page. This change fleshes out our testing
    further, adding tests for the view, which encompasses all the stages of
    ReviewRequestPageData along with other page components (actions,
    JavaScript setup, etc.).

   
  +

Review requests bound to repositories now use hosting services, which

  + ensures a bit more test coverage (and unveils issues surrounding
  + re-querying of repositories and other objects).

  +
   

This gives a more comprehensive view of where database queries need to

    be optimized.

Commits:
Summary ID
Add unit tests for the review request view.
A recent change introduced unit tests for `ReviewRequestPageData`, which backs the review request page. This change fleshes out our testing further, adding tests for the view, which encompasses all the stages of `ReviewRequestPageData` along with other page components (actions, JavaScript setup, etc.). This gives a more comprehensive view of where database queries need to be optimized.
9a155b6973703ba5f8c4482a072f958ae9c91fc9
Add unit tests for the review request view.
A recent change introduced unit tests for `ReviewRequestPageData`, which backs the review request page. This change fleshes out our testing further, adding tests for the view, which encompasses all the stages of `ReviewRequestPageData` along with other page components (actions, JavaScript setup, etc.). Review requests bound to repositories now use hosting services, which ensures a bit more test coverage (and unveils issues surrounding re-querying of repositories and other objects). This gives a more comprehensive view of where database queries need to be optimized.
4c8d997525241e245c3069724036c9f4e4d4bdf7

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
maubin
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2.