Modernized function typing in reviewboard/accounts/models.py

Review Request #14106 — Created Aug. 16, 2024 and submitted — Latest diff uploaded

Information

Review Board
master

Reviewers

Modernized function typing in reviewboard/accounts/models.py

No new tests were added, however the entire reviewboard test suite
was run and all previously passing tests still pass.

Changes between revision 3 and 4

orig
1
2
3
4
5

Commits

Summary ID Author
Modernized function typing in reviewboard/accounts/models.py
Added typing to all the function parameters and return types in every function to bring the file in line with more modern typing standards. Certain type imports were put under a `TYPE_CHECKING`. No new tests were added, however the entire `reviewboard` test suite was run and all previously passing tests still pass.
d72bc111c58e20f2fa7a9a78eac84e1d0f19e14a Daniel
Modernized function typing in reviewboard/accounts/models.py
Added typing to all the function parameters and return types in every function to bring the file in line with more modern typing standards. Certain type imports were put under a `TYPE_CHECKING`. No new tests were added, however the entire `reviewboard` test suite was run and all previously passing tests still pass.
86371cd3e2f0740f6ea2747d28409eaaf059475a Daniel

Files

reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts
reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts
reviewboard/static/rb/js/reviews/views/reviewablePageView.ts
reviewboard/static/rb/js/reviews/views/unifiedBannerView.ts
reviewboard/static/rb/js/reviews/views/tests/commentDialogViewTests.ts
reviewboard/static/rb/js/reviews/views/tests/commentIssueBarViewTests.ts
reviewboard/static/rb/js/tests/index.ts
reviewboard/static/rb/js/ui/views/tests/index.ts
reviewboard/static/rb/js/ui/views/tests/menuButtonViewTests.es6.js Was reviewboard/static/rb/js/ui/views/tests/menuButtonViewTests.ts
reviewboard/static/rb/js/ui/views/tests/menuViewTests.es6.js Was reviewboard/static/rb/js/ui/views/tests/menuViewTests.ts
reviewboard/static/rb/js/views/clientLoginView.es6.js
reviewboard/static/rb/js/views/draftReviewBannerView.es6.js
reviewboard/static/rb/js/views/tests/clientLoginViewTests.es6.js
reviewboard/static/rb/js/views/tests/draftReviewBannerViewTests.es6.js
reviewboard/static/rb/js/widgets/index.ts Deleted
reviewboard/static/rb/js/widgets/views/oauthClientSecretView.ts Deleted
reviewboard/templates/accounts/client_login.html
reviewboard/templates/accounts/edit_oauth_app.html
reviewboard/templates/admin/base_site.html
reviewboard/templates/notifications/reply_email.txt
reviewboard/templates/oauth/secret_input_widget.html
reviewboard/templates/reviews/changedesc_file_attachment.html
reviewboard/templates/search/_user.html
reviewboard/templates/search/results.html
reviewboard/webapi/resources/hosting_service_account.py
reviewboard/webapi/tests/test_hosting_service_account.py
reviewboard/webapi/tests/test_repository.py
This diff has been split across 6 pages: < 1 2 3 4 5 6
reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts
reviewboard/static/rb/js/reviews/views/reviewRequestFieldViews.ts
reviewboard/static/rb/js/reviews/views/reviewablePageView.ts
reviewboard/static/rb/js/reviews/views/unifiedBannerView.ts
reviewboard/static/rb/js/reviews/views/tests/commentDialogViewTests.ts
reviewboard/static/rb/js/reviews/views/tests/commentIssueBarViewTests.ts
reviewboard/static/rb/js/tests/index.ts
reviewboard/static/rb/js/ui/views/tests/index.ts
reviewboard/static/rb/js/ui/views/tests/menuButtonViewTests.ts
reviewboard/static/rb/js/ui/views/tests/menuViewTests.ts
reviewboard/static/rb/js/views/clientLoginView.es6.js
reviewboard/static/rb/js/views/draftReviewBannerView.es6.js
reviewboard/static/rb/js/views/tests/clientLoginViewTests.es6.js
reviewboard/static/rb/js/views/tests/draftReviewBannerViewTests.es6.js
reviewboard/static/rb/js/widgets/index.ts
reviewboard/static/rb/js/widgets/views/oauthClientSecretView.ts
reviewboard/templates/accounts/client_login.html
reviewboard/templates/accounts/edit_oauth_app.html
reviewboard/templates/admin/base_site.html
reviewboard/templates/notifications/reply_email.txt
reviewboard/templates/oauth/secret_input_widget.html
reviewboard/templates/reviews/changedesc_file_attachment.html
reviewboard/templates/search/_user.html
reviewboard/templates/search/results.html
reviewboard/webapi/resources/hosting_service_account.py
reviewboard/webapi/tests/test_hosting_service_account.py
reviewboard/webapi/tests/test_repository.py
This diff has been split across 6 pages: < 1 2 3 4 5 6
Loading...