Modernized function typing in reviewboard/accounts/models.py

Review Request #14106 — Created Aug. 16, 2024 and submitted — Latest diff uploaded

Information

Review Board
master

Reviewers

Modernized function typing in reviewboard/accounts/models.py

No new tests were added, however the entire reviewboard test suite
was run and all previously passing tests still pass.

Changes between revision 3 and 4

orig
1
2
3
4
5

Commits

Summary ID Author
Modernized function typing in reviewboard/accounts/models.py
Added typing to all the function parameters and return types in every function to bring the file in line with more modern typing standards. Certain type imports were put under a `TYPE_CHECKING`. No new tests were added, however the entire `reviewboard` test suite was run and all previously passing tests still pass.
d72bc111c58e20f2fa7a9a78eac84e1d0f19e14a Daniel
Modernized function typing in reviewboard/accounts/models.py
Added typing to all the function parameters and return types in every function to bring the file in line with more modern typing standards. Certain type imports were put under a `TYPE_CHECKING`. No new tests were added, however the entire `reviewboard` test suite was run and all previously passing tests still pass.
86371cd3e2f0740f6ea2747d28409eaaf059475a Daniel

Files

reviewboard/static/rb/js/accountPrefsPage/views/oauthTokensView.es6.js
reviewboard/static/rb/js/common/index.ts
reviewboard/static/rb/js/common/resources/index.ts
reviewboard/static/rb/js/common/resources/collections/repositoryBranchesCollection.ts Deleted
reviewboard/static/rb/js/common/resources/collections/tests/index.ts
reviewboard/static/rb/js/common/resources/models/baseCommentModel.ts
reviewboard/static/rb/js/common/resources/models/baseCommentReplyModel.ts Deleted
reviewboard/static/rb/js/common/resources/models/diffCommentModel.ts Deleted
reviewboard/static/rb/js/common/resources/models/diffCommentReplyModel.ts Deleted
reviewboard/static/rb/js/common/resources/models/diffModel.ts Deleted
reviewboard/static/rb/js/common/resources/models/draftResourceModelMixin.ts
reviewboard/static/rb/js/common/resources/models/draftReviewRequestModel.ts Deleted
reviewboard/static/rb/js/common/resources/models/fileAttachmentCommentModel.ts Deleted
reviewboard/static/rb/js/common/resources/models/fileAttachmentCommentReplyModel.ts Deleted
reviewboard/static/rb/js/common/resources/models/fileDiffModel.ts Deleted
reviewboard/static/rb/js/common/resources/models/generalCommentModel.ts Deleted
reviewboard/static/rb/js/common/resources/models/generalCommentReplyModel.ts Deleted
reviewboard/static/rb/js/common/resources/models/repositoryBranchModel.ts Deleted
reviewboard/static/rb/js/common/resources/models/repositoryCommitModel.ts Deleted
reviewboard/static/rb/js/common/resources/models/repositoryModel.ts
This diff has been split across 6 pages: < 1 2 3 4 5 6 >
reviewboard/static/rb/js/accountPrefsPage/views/oauthTokensView.es6.js
reviewboard/static/rb/js/common/index.ts
reviewboard/static/rb/js/common/resources/index.ts
reviewboard/static/rb/js/common/resources/collections/repositoryBranchesCollection.ts
reviewboard/static/rb/js/common/resources/collections/tests/index.ts
reviewboard/static/rb/js/common/resources/models/baseCommentModel.ts
reviewboard/static/rb/js/common/resources/models/baseCommentReplyModel.ts
reviewboard/static/rb/js/common/resources/models/diffCommentModel.ts
reviewboard/static/rb/js/common/resources/models/diffCommentReplyModel.ts
reviewboard/static/rb/js/common/resources/models/diffModel.ts
reviewboard/static/rb/js/common/resources/models/draftResourceModelMixin.ts
reviewboard/static/rb/js/common/resources/models/draftReviewRequestModel.ts
reviewboard/static/rb/js/common/resources/models/fileAttachmentCommentModel.ts
reviewboard/static/rb/js/common/resources/models/fileAttachmentCommentReplyModel.ts
reviewboard/static/rb/js/common/resources/models/fileDiffModel.ts
reviewboard/static/rb/js/common/resources/models/generalCommentModel.ts
reviewboard/static/rb/js/common/resources/models/generalCommentReplyModel.ts
reviewboard/static/rb/js/common/resources/models/repositoryBranchModel.ts
reviewboard/static/rb/js/common/resources/models/repositoryCommitModel.ts
reviewboard/static/rb/js/common/resources/models/repositoryModel.ts
This diff has been split across 6 pages: < 1 2 3 4 5 6 >
Loading...