Add support for matching join types in equeries.

Review Request #13424 — Created Nov. 18, 2023 and submitted — Latest diff uploaded

Information

Djblets
release-3.x

Reviewers

This introduces a join_types field for equeries, which helps
instrument join types (such as INNER vs. OUTER JOINs). That can be
useful in ensuring that queries are joining in a way that the developers
expect, which can have an impact on results.

This is off by default, for compatibility. If a mismatch would have been
reported, then a warning will be issued advising the developer to opt in
and that it will be made the default in a future version.

There's also a fix for formatting sets, ensuring they're both sorted
and pretty-printed.

Unit tests pass.

Made use of this in some in-progress tests.

Diff Revision 2

This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

orig
1
2
3

Commits

First Last Summary ID Author
Add support for matching join types in equeries.
This introduces a `join_types` field for equeries, which helps instrument join types (such as INNER vs. OUTER JOINs). That can be useful in ensuring that queries are joining in a way that the developers expect, which can have an impact on results. This is off by default, for compatibility. If a mismatch would have been reported, then a warning will be issued advising the developer to opt in and that it will be made the default in a future version.
3e6c0ff3cfad126440b02b30bfb0f4665a87048d Christian Hammond
djblets/db/query_comparator.py
djblets/db/tests/test_query_comparator.py
djblets/testing/testcases.py
Loading...