Add support for matching join types in equeries.
Review Request #13424 — Created Nov. 18, 2023 and submitted
This introduces a
join_types
field for equeries, which helps
instrument join types (such as INNER vs. OUTER JOINs). That can be
useful in ensuring that queries are joining in a way that the developers
expect, which can have an impact on results.This is off by default, for compatibility. If a mismatch would have been
reported, then a warning will be issued advising the developer to opt in
and that it will be made the default in a future version.There's also a fix for formatting
set
s, ensuring they're both sorted
and pretty-printed.
Unit tests pass.
Made use of this in some in-progress tests.
Summary | ID |
---|---|
39a8aab653ca7aa5d5689e13e365e5887ba780bd |
Description | From | Last Updated |
---|---|---|
'djblets.deprecation.RemovedInDjblets50Warning' imported but unused Column: 1 Error code: F401 |
reviewbot | |
dictionary key '_unchecked_mismatched_attrs' repeated with different values Column: 17 Error code: F601 |
reviewbot | |
dictionary key '_unchecked_mismatched_attrs' repeated with different values Column: 17 Error code: F601 |
reviewbot |
- Change Summary:
-
- Fixed table names appearing in
join_types
that aren't actually part of a true join (they were just considered for one internally). - Changed how opt-in and deprecation for this feature works.
- Removed an unused import.
- Fixed a duplicate key in a dictionary.
- Fixed table names appearing in
- Commits:
-
Summary ID 109154d493bd90124cc03a0d1f7b70cef193141e 3e6c0ff3cfad126440b02b30bfb0f4665a87048d