Fix up a couple broken js-tests.

 






 

 


  Review Request #12971
  —
  Created April 21, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Over the course of a bunch of revisions, a couple small regressions

slipped into the js-tests. This fixes them:


    

  1. The DiffViewerPageTests was triggering the new assertion that the
    
   dock element exists.
    2. 

  2. Moving the "Edit Review" action into the review menu in the unified
    
   banner meant that tests for the old action would fail and should not
    
   be run.
    3. 


 








  


 
 

  
Ran js-tests.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix up a couple broken js-tests.
     
Over the course of a bunch of revisions, a couple small regressions
slipped into the js-tests. This fixes them:

1. The DiffViewerPageTests was triggering the new assertion that the
   dock element exists.
2. Moving the "Edit Review" action into the review menu in the unified
   banner meant that tests for the old action would fail and should not
   be run.

Testing Done:
Ran js-tests.

    

   
  		
  13a3f10461a2538943f53a206c0f0416e72a11a2
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/tests/diffViewerPageViewTests.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/tests/reviewablePageViewTests.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...