Summary

Fix up a couple broken js-tests.

Review Request #12971 — Created April 21, 2023 and submitted April 25, 2023, 11:42 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Over the course of a bunch of revisions, a couple small regressions
slipped into the js-tests. This fixes them:

The DiffViewerPageTests was triggering the new assertion that the
dock element exists.
Moving the "Edit Review" action into the review menu in the unified
banner meant that tests for the old action would fail and should not
be run.

Testing Done

Ran js-tests.

Commits

Summary	ID
Fix up a couple broken js-tests. Over the course of a bunch of revisions, a couple small regressions slipped into the js-tests. This fixes them: 1. The DiffViewerPageTests was triggering the new assertion that the dock element exists. 2. Moving the "Edit Review" action into the review menu in the unified banner meant that tests for the old action would fail and should not be run. Testing Done: Ran js-tests.	13a3f10461a2538943f53a206c0f0416e72a11a2

Summary

Fix up a couple broken js-tests.

Over the course of a bunch of revisions, a couple small regressions slipped into the js-tests. This fixes them: 1. The DiffViewerPageTests was triggering the new assertion that the dock element exists. 2. Moving the "Edit Review" action into the review menu in the unified banner meant that tests for the old action would fail and should not be run. Testing Done: Ran js-tests.

13a3f10461a2538943f53a206c0f0416e72a11a2

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-6.x (be92ec5)