Summary

Add RepositoryForm for tracking repository config options and state.

Review Request #12754 — Created Dec. 9, 2022 and updated Feb. 1, 2023, 10:18 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

12750

Reviewers

Groups

reviewboard

People

Description

This introduces RepositoryForm, which is now created when
instantiating the repository configuration page. This parses model state
from the server-side form, creating collections of SCMTool, hosting
service, and account options for configuration.

This will soon contain logic and additional configuration state, for the
purpose of creating a more dynamic client-side-driven repository
configuration experience.

For now, little has changed, except some global variables
(HOSTING_SERVICES and TOOLS_INFO) and some stored state from the DOM
(the list of original SCMTools) have been updated to use the new form
model capabilities.

There's also some code removed for disabling form inputs when showing a
SSL cert or SSH key confirmation. This hasn't worked since Review Board
3, and this will all be replaced in time anyway. This code existed in a
file that's now being removed, so for now, it's just going away.

Repository form code now lives in the main "admin" bundle, and unit
tests have been added for the form model.

Testing Done

Unit tests passed.

Tested that repository form loading worked, and that all operations that
query hosting service information or tools and update configuration all
behave as normal.

Commits

Summary	ID
Add RepositoryForm for tracking repository config options and state. This introduces `RepositoryForm`, which is now created when instantiating the repository configuration page. This parses model state from the server-side form, creating collections of SCMTool, hosting service, and account options for configuration. This will soon contain logic and additional configuration state, for the purpose of creating a more dynamic client-side-driven repository configuration experience. For now, little has changed, except some global variables (`HOSTING_SERVICES` and `TOOLS_INFO`) and some stored state from the DOM (the list of original SCMTools) have been updated to use the new form model capabilities. There's also some code removed for disabling form inputs when showing a SSL cert or SSH key confirmation. This hasn't worked since Review Board 3, and this will all be replaced in time anyway. This code existed in a file that's now being removed, so for now, it's just going away. Repository form code now lives in the main "admin" bundle, and unit tests have been added for the form model.	70f59fdb6ddc06ea4c6567acab8efc3d9d3f12a5

Summary

Add RepositoryForm for tracking repository config options and state.

This introduces `RepositoryForm`, which is now created when instantiating the repository configuration page. This parses model state from the server-side form, creating collections of SCMTool, hosting service, and account options for configuration. This will soon contain logic and additional configuration state, for the purpose of creating a more dynamic client-side-driven repository configuration experience. For now, little has changed, except some global variables (`HOSTING_SERVICES` and `TOOLS_INFO`) and some stored state from the DOM (the list of original SCMTools) have been updated to use the new form model capabilities. There's also some code removed for disabling form inputs when showing a SSL cert or SSH key confirmation. This hasn't worked since Review Board 3, and this will all be replaced in time anyway. This code existed in a file that's now being removed, so for now, it's just going away. Repository form code now lives in the main "admin" bundle, and unit tests have been added for the form model.

70f59fdb6ddc06ea4c6567acab8efc3d9d3f12a5

Issues

Description	From	Last Updated
'django.http.HttpRequest' imported but unused Column: 1 Error code: F401	reviewbot	Dec. 9, 2022, 11:44 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/scmtools/forms.py (Diff revision 1)

Show all issues

'django.http.HttpRequest' imported but unused

Column: 1
Error code: F401

Change Summary:

Renamed some variables, functions, and payload keys to make it clear that the SCMTools and hosting services are options for the form, not data.

Commits:

	Summary	ID
	Add RepositoryForm for tracking repository config options and state. This introduces `RepositoryForm`, which is now created when instantiating the repository configuration page. This parses model state from the server-side form, creating collections of SCMTool, hosting service, and account options for configuration. This will soon contain logic and additional configuration state, for the purpose of creating a more dynamic client-side-driven repository configuration experience. For now, little has changed, except some global variables (`HOSTING_SERVICES` and `TOOLS_INFO`) and some stored state from the DOM (the list of original SCMTools) have been updated to use the new form model capabilities. There's also some code removed for disabling form inputs when showing a SSL cert or SSH key confirmation. This hasn't worked since Review Board 3, and this will all be replaced in time anyway. This code existed in a file that's now being removed, so for now, it's just going away. Repository form code now lives in the main "admin" bundle, and unit tests have been added for the form model.	1d11b66ba4f534ca6157a1baa86989acc7f292c8
	Add RepositoryForm for tracking repository config options and state. This introduces `RepositoryForm`, which is now created when instantiating the repository configuration page. This parses model state from the server-side form, creating collections of SCMTool, hosting service, and account options for configuration. This will soon contain logic and additional configuration state, for the purpose of creating a more dynamic client-side-driven repository configuration experience. For now, little has changed, except some global variables (`HOSTING_SERVICES` and `TOOLS_INFO`) and some stored state from the DOM (the list of original SCMTools) have been updated to use the new form model capabilities. There's also some code removed for disabling form inputs when showing a SSL cert or SSH key confirmation. This hasn't worked since Review Board 3, and this will all be replaced in time anyway. This code existed in a file that's now being removed, so for now, it's just going away. Repository form code now lives in the main "admin" bundle, and unit tests have been added for the form model.	d871c607f4953b1b28057b83629d07e44c463de5

Diff:

Revision 2 (+1290 -202)

Show changes

	reviewboard/staticbundles.py
	reviewboard/scmtools/forms.py
	reviewboard/static/rb/js/admin/models/repositoryFormModel.es6.js
	reviewboard/static/rb/js/admin/models/tests/repositoryFormModelTests.es6.js
	reviewboard/static/rb/js/admin/views/repositoryFormView.es6.js
	reviewboard/templates/admin/scmtools/repository/change_form.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Missed a function rename.

Commits:

	Summary	ID
	Add RepositoryForm for tracking repository config options and state. This introduces `RepositoryForm`, which is now created when instantiating the repository configuration page. This parses model state from the server-side form, creating collections of SCMTool, hosting service, and account options for configuration. This will soon contain logic and additional configuration state, for the purpose of creating a more dynamic client-side-driven repository configuration experience. For now, little has changed, except some global variables (`HOSTING_SERVICES` and `TOOLS_INFO`) and some stored state from the DOM (the list of original SCMTools) have been updated to use the new form model capabilities. There's also some code removed for disabling form inputs when showing a SSL cert or SSH key confirmation. This hasn't worked since Review Board 3, and this will all be replaced in time anyway. This code existed in a file that's now being removed, so for now, it's just going away. Repository form code now lives in the main "admin" bundle, and unit tests have been added for the form model.	d871c607f4953b1b28057b83629d07e44c463de5
	Add RepositoryForm for tracking repository config options and state. This introduces `RepositoryForm`, which is now created when instantiating the repository configuration page. This parses model state from the server-side form, creating collections of SCMTool, hosting service, and account options for configuration. This will soon contain logic and additional configuration state, for the purpose of creating a more dynamic client-side-driven repository configuration experience. For now, little has changed, except some global variables (`HOSTING_SERVICES` and `TOOLS_INFO`) and some stored state from the DOM (the list of original SCMTools) have been updated to use the new form model capabilities. There's also some code removed for disabling form inputs when showing a SSL cert or SSH key confirmation. This hasn't worked since Review Board 3, and this will all be replaced in time anyway. This code existed in a file that's now being removed, so for now, it's just going away. Repository form code now lives in the main "admin" bundle, and unit tests have been added for the form model.	aedce9856a515ff8c44a6dbb912f3417b61ddc3e

Diff:

Revision 3 (+1290 -202)

Show changes

	reviewboard/staticbundles.py
	reviewboard/scmtools/forms.py
	reviewboard/static/rb/js/admin/models/repositoryFormModel.es6.js
	reviewboard/static/rb/js/admin/models/tests/repositoryFormModelTests.es6.js
	reviewboard/static/rb/js/admin/views/repositoryFormView.es6.js
	reviewboard/templates/admin/scmtools/repository/change_form.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Change Summary:


Converted collection loops from .forEach() to for..of.
Fixed bad variable references.

Commits:

	Summary	ID
	Add RepositoryForm for tracking repository config options and state. This introduces `RepositoryForm`, which is now created when instantiating the repository configuration page. This parses model state from the server-side form, creating collections of SCMTool, hosting service, and account options for configuration. This will soon contain logic and additional configuration state, for the purpose of creating a more dynamic client-side-driven repository configuration experience. For now, little has changed, except some global variables (`HOSTING_SERVICES` and `TOOLS_INFO`) and some stored state from the DOM (the list of original SCMTools) have been updated to use the new form model capabilities. There's also some code removed for disabling form inputs when showing a SSL cert or SSH key confirmation. This hasn't worked since Review Board 3, and this will all be replaced in time anyway. This code existed in a file that's now being removed, so for now, it's just going away. Repository form code now lives in the main "admin" bundle, and unit tests have been added for the form model.	aedce9856a515ff8c44a6dbb912f3417b61ddc3e
	Add RepositoryForm for tracking repository config options and state. This introduces `RepositoryForm`, which is now created when instantiating the repository configuration page. This parses model state from the server-side form, creating collections of SCMTool, hosting service, and account options for configuration. This will soon contain logic and additional configuration state, for the purpose of creating a more dynamic client-side-driven repository configuration experience. For now, little has changed, except some global variables (`HOSTING_SERVICES` and `TOOLS_INFO`) and some stored state from the DOM (the list of original SCMTools) have been updated to use the new form model capabilities. There's also some code removed for disabling form inputs when showing a SSL cert or SSH key confirmation. This hasn't worked since Review Board 3, and this will all be replaced in time anyway. This code existed in a file that's now being removed, so for now, it's just going away. Repository form code now lives in the main "admin" bundle, and unit tests have been added for the form model.	1c5383d473237eb58b45a941eaae93ed032c919e

Diff:

Revision 4 (+1288 -210)

Show changes

	reviewboard/staticbundles.py
	reviewboard/scmtools/forms.py
	reviewboard/static/rb/js/admin/models/repositoryFormModel.es6.js
	reviewboard/static/rb/js/admin/models/tests/repositoryFormModelTests.es6.js
	reviewboard/static/rb/js/admin/views/repositoryFormView.es6.js
	reviewboard/templates/admin/scmtools/repository/change_form.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Depends On:

+	12750 - Port the repository config code to Backbone.

Change Summary:

Updated a couple references to old key names to new equivalents.

Commits:

	Summary	ID
	Add RepositoryForm for tracking repository config options and state. This introduces `RepositoryForm`, which is now created when instantiating the repository configuration page. This parses model state from the server-side form, creating collections of SCMTool, hosting service, and account options for configuration. This will soon contain logic and additional configuration state, for the purpose of creating a more dynamic client-side-driven repository configuration experience. For now, little has changed, except some global variables (`HOSTING_SERVICES` and `TOOLS_INFO`) and some stored state from the DOM (the list of original SCMTools) have been updated to use the new form model capabilities. There's also some code removed for disabling form inputs when showing a SSL cert or SSH key confirmation. This hasn't worked since Review Board 3, and this will all be replaced in time anyway. This code existed in a file that's now being removed, so for now, it's just going away. Repository form code now lives in the main "admin" bundle, and unit tests have been added for the form model.	1c5383d473237eb58b45a941eaae93ed032c919e
	Add RepositoryForm for tracking repository config options and state. This introduces `RepositoryForm`, which is now created when instantiating the repository configuration page. This parses model state from the server-side form, creating collections of SCMTool, hosting service, and account options for configuration. This will soon contain logic and additional configuration state, for the purpose of creating a more dynamic client-side-driven repository configuration experience. For now, little has changed, except some global variables (`HOSTING_SERVICES` and `TOOLS_INFO`) and some stored state from the DOM (the list of original SCMTools) have been updated to use the new form model capabilities. There's also some code removed for disabling form inputs when showing a SSL cert or SSH key confirmation. This hasn't worked since Review Board 3, and this will all be replaced in time anyway. This code existed in a file that's now being removed, so for now, it's just going away. Repository form code now lives in the main "admin" bundle, and unit tests have been added for the form model.	d38d098c9d1d3c9d9a89a7c7582a8d28bd424776

Diff:

Revision 5 (+1288 -210)

Show changes

	reviewboard/staticbundles.py
	reviewboard/scmtools/forms.py
	reviewboard/static/rb/js/admin/models/repositoryFormModel.es6.js
	reviewboard/static/rb/js/admin/models/tests/repositoryFormModelTests.es6.js
	reviewboard/static/rb/js/admin/views/repositoryFormView.es6.js
	reviewboard/templates/admin/scmtools/repository/change_form.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Attempt 2: Updated a couple references to old key names to new equivalents.

Commits:

	Summary	ID
	Add RepositoryForm for tracking repository config options and state. This introduces `RepositoryForm`, which is now created when instantiating the repository configuration page. This parses model state from the server-side form, creating collections of SCMTool, hosting service, and account options for configuration. This will soon contain logic and additional configuration state, for the purpose of creating a more dynamic client-side-driven repository configuration experience. For now, little has changed, except some global variables (`HOSTING_SERVICES` and `TOOLS_INFO`) and some stored state from the DOM (the list of original SCMTools) have been updated to use the new form model capabilities. There's also some code removed for disabling form inputs when showing a SSL cert or SSH key confirmation. This hasn't worked since Review Board 3, and this will all be replaced in time anyway. This code existed in a file that's now being removed, so for now, it's just going away. Repository form code now lives in the main "admin" bundle, and unit tests have been added for the form model.	d38d098c9d1d3c9d9a89a7c7582a8d28bd424776
	Add RepositoryForm for tracking repository config options and state. This introduces `RepositoryForm`, which is now created when instantiating the repository configuration page. This parses model state from the server-side form, creating collections of SCMTool, hosting service, and account options for configuration. This will soon contain logic and additional configuration state, for the purpose of creating a more dynamic client-side-driven repository configuration experience. For now, little has changed, except some global variables (`HOSTING_SERVICES` and `TOOLS_INFO`) and some stored state from the DOM (the list of original SCMTools) have been updated to use the new form model capabilities. There's also some code removed for disabling form inputs when showing a SSL cert or SSH key confirmation. This hasn't worked since Review Board 3, and this will all be replaced in time anyway. This code existed in a file that's now being removed, so for now, it's just going away. Repository form code now lives in the main "admin" bundle, and unit tests have been added for the form model.	70f59fdb6ddc06ea4c6567acab8efc3d9d3f12a5

Diff:

Revision 6 (+1294 -216)

Show changes

	reviewboard/staticbundles.py
	reviewboard/scmtools/forms.py
	reviewboard/scmtools/tests/test_repository_form.py
	reviewboard/static/rb/js/admin/models/repositoryFormModel.es6.js
	reviewboard/static/rb/js/admin/models/tests/repositoryFormModelTests.es6.js
	reviewboard/static/rb/js/admin/views/repositoryFormView.es6.js
	reviewboard/templates/admin/scmtools/repository/change_form.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```