Change ReviewRequestVisit.objects.update_visibility to use upsert.

Review Request #12697 — Created Oct. 25, 2022 and submitted — Latest diff uploaded

Information

Review Board
release-6.x

Reviewers

Django has a new(ish) method for handling upserts itself,
update_or_create. Switching to this actually fixes a bug in the
existing code where update_visibility wasn't updating the timestamp if
the visibility wasn't changing.

While updating this, I noticed that the unit tests for these weren't in
the accounts/tests/ directory so I've moved that too.

Ran unit tests.

Commits

Files