flake8
passed.
JSHint
passed.
Review Request #12697 — Created Oct. 25, 2022 and submitted
Information | |
---|---|
david | |
Review Board | |
release-6.x | |
Reviewers | |
reviewboard | |
Django has a new(ish) method for handling upserts itself,
update_or_create
. Switching to this actually fixes a bug in the
existing code whereupdate_visibility
wasn't updating the timestamp if
the visibility wasn't changing.While updating this, I noticed that the unit tests for these weren't in
theaccounts/tests/
directory so I've moved that too.
Ran unit tests.
Summary | |
---|---|
Description | From | Last Updated |
---|---|---|
This can be one statement now, just tacking on a [0]. |
|
Add an unstaged change: switch to
assertQueries
in order to handle savepoints.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+34 -14) |
reviewboard/accounts/managers.py (Diff revision 2) |
---|
This can be one statement now, just tacking on a
[0]
.