Summary

Change ReviewRequestVisit.objects.update_visibility to use upsert.

Review Request #12697 — Created Oct. 25, 2022 and submitted Oct. 27, 2022, 11:17 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Django has a new(ish) method for handling upserts itself,
update_or_create. Switching to this actually fixes a bug in the
existing code where update_visibility wasn't updating the timestamp if
the visibility wasn't changing.

While updating this, I noticed that the unit tests for these weren't in
the accounts/tests/ directory so I've moved that too.

Testing Done

Ran unit tests.

Commits

Summary	ID
Change ReviewRequestVisit.objects.update_visibility to use upsert. Django has a new(ish) method for handling upserts itself, `update_or_create`. Switching to this actually fixes a bug in the existing code where `update_visibility` wasn't updating the timestamp if the visibility wasn't changing. While updating this, I noticed that the unit tests for these weren't in the `accounts/tests/` directory so I've moved that too. Testing Done: Ran unit tests.	dcf05a61d1e1bf959f22759fc6f2af8de91949a0

Summary

Change ReviewRequestVisit.objects.update_visibility to use upsert.

Django has a new(ish) method for handling upserts itself, `update_or_create`. Switching to this actually fixes a bug in the existing code where `update_visibility` wasn't updating the timestamp if the visibility wasn't changing. While updating this, I noticed that the unit tests for these weren't in the `accounts/tests/` directory so I've moved that too. Testing Done: Ran unit tests.

dcf05a61d1e1bf959f22759fc6f2af8de91949a0

Issues

Description	From	Last Updated
This can be one statement now, just tacking on a [0].	chipx86	Oct. 27, 2022, 11:17 a.m.

flake8 passed.

JSHint passed.

Change Summary:

Add an unstaged change: switch to assertQueries in order to handle savepoints.

Commits:

	Summary	ID
	Change ReviewRequestVisit.objects.update_visibility to use upsert. Django has a new(ish) method for handling upserts itself, `update_or_create`. Switching to this actually fixes a bug in the existing code where `update_visibility` wasn't updating the timestamp if the visibility wasn't changing. While updating this, I noticed that the unit tests for these weren't in the `accounts/tests/` directory so I've moved that too. Testing Done: Ran unit tests.	3f262589fb256c6439ee395f70cf829ce09101d8
	Change ReviewRequestVisit.objects.update_visibility to use upsert. Django has a new(ish) method for handling upserts itself, `update_or_create`. Switching to this actually fixes a bug in the existing code where `update_visibility` wasn't updating the timestamp if the visibility wasn't changing. While updating this, I noticed that the unit tests for these weren't in the `accounts/tests/` directory so I've moved that too. Testing Done: Ran unit tests.	dcf05a61d1e1bf959f22759fc6f2af8de91949a0

Diff:

Revision 2 (+34 -14)

Show changes

	reviewboard/accounts/managers.py
	reviewboard/accounts/test_review_request_visit_manager.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/accounts/managers.py (Diff revision 2)

The issue has been resolved. Show all issues

This can be one statement now, just tacking on a [0].

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (2e49a4a)