Summary

Add release notes for Review Board 5.0.

Review Request #12660 — Created Sept. 30, 2022 and submitted Oct. 4, 2022, 5:48 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This is a large release, moving onto modern architecture, and

introducing many new features for reviewers and administrators. This

includes Stale Ship-It! indicators, Trojan Source detection, Single

Sign-On, and more.
This change adds release notes covering all the public changes we want

to advertise for the release.
This lacks screenshots, but the plan is to add them in a follow-up

change.

Testing Done

Built the release notes. Checked for spelling errors, bad links, and
build errors.

Commits

Summary	ID
Add release notes for Review Board 5.0. This is a large release, moving onto modern architecture, and introducing many new features for reviewers and administrators. This includes Stale Ship-It! indicators, Trojan Source detection, Single Sign-On, and more. This change adds release notes covering all the public changes we want to advertise for the release.	25f0bd7452b4bde7d0d299952dd9dd999ac80333

Issues

Description	From	Last Updated
Typo: priority -> prioritize	maubin	Oct. 3, 2022, 8:54 p.m.
There's really only one underscore in our token prefix.	maubin	Oct. 3, 2022, 8:54 p.m.
Could mention that we fixed a crash when trying to set custom API token policies.	maubin	Oct. 4, 2022, 8:10 a.m.

flake8 passed.

JSHint passed.

docs/releasenotes/5.0.rst (Diff revision 1)
The issue has been resolved. Show all issues
```
Typo: priority -> prioritize
```
docs/releasenotes/5.0.rst (Diff revision 1)
The issue has been resolved. Show all issues
```
There's really only one underscore in our token prefix.
```

docs/releasenotes/5.0.rst (Diff revision 1)

The issue has been resolved. Show all issues

Could mention that we fixed a crash when trying to set custom API token policies.

chipx86 Oct. 3, 2022, 8:55 p.m.

Was this something that affected RB4, or was it a bug that only occurred with the new API token UI work?

maubin Oct. 3, 2022, 9:54 p.m.

This bug did not affect RB4, it was introduced in this change /r/11642 when a try block was split into two separate ones, making the policy variable become out of scope for the second block. So when you clicked on "save" in the editor it wouldn't actually save and the editor wouldn't close. The 2nd bug, where canceling out of the policy editor would revert to the 2nd previous value instead of the previous one, also appeared in RB4. The fixes are in this change /r/12616

chipx86 Oct. 3, 2022, 9:57 p.m.

Ah okay. I'm leaving out the changes between RC1 and final, and just focusing on what's new in the final release compared to the previous series.

Sounds like the second bug is worth including though.

maubin Oct. 3, 2022, 10:01 p.m.

Sounds good. Also should I backport the second bug fix to 4.0.x?

chipx86 Oct. 3, 2022, 10:01 p.m.

If it's really trivial to do, sure. If it's not, then we can leave it, as it's probably rarely hit.

Change Summary:


Fixed typos in the release notes.
Added a bug fix for the API token policy editor.

Commits:

	Summary	ID
	Add release notes for Review Board 5.0. This is a large release, moving onto modern architecture, and introducing many new features for reviewers and administrators. This includes Stale Ship-It! indicators, Trojan Source detection, Single Sign-On, and more. This change adds release notes covering all the public changes we want to advertise for the release.	d18fcdbaa76de870ed2b5b922859bee528826ec3
	Add release notes for Review Board 5.0. This is a large release, moving onto modern architecture, and introducing many new features for reviewers and administrators. This includes Stale Ship-It! indicators, Trojan Source detection, Single Sign-On, and more. This change adds release notes covering all the public changes we want to advertise for the release.	25f0bd7452b4bde7d0d299952dd9dd999ac80333

Diff:

Revision 2 (+752)

Show changes

	docs/releasenotes/5.0.rst
	docs/releasenotes/index.rst

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.0.x (eb40d53)