Summary:

Fix bugs in the API tokens config page.

Review Request #12616 — Created Sept. 21, 2022 and submitted Sept. 28, 2022, 10:03 a.m.

Information
Owner:	maubin
Repository:	Review Board
Branch:	release-5.0.x
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

While testing the new token expiration controls on the API tokens page, it was
discovered that the displayed expiration date would revert to an old value
whenever the policy type changed. To fix this, we update the displayed
expiration date whenever its value changes and whenever the token's information
is rendered.

This change also fixes two bugs related to the custom policy editor. The first
being that you couldn't set custom policies due to an out of scope variable.
Secondly, canceling out of the custom policy editor would sometimes revert to
the wrong value. This would happen for tokens that currently have a custom
policy set.

Testing Done


Manually tested a bunch of combinations of changing expiration dates,

  policies and notes on the tokens config page.
Ran JS unit tests.

Commits

Summary
Fix bugs on API tokens config page.

Screenshots

Issues

Description	From	Last Updated
Typo in description: woudl -> would	david	Sept. 22, 2022, 9:08 a.m.
In this case, we'll alert but then continue on below and try to save with an undefined policy. Seems like …	david	Sept. 22, 2022, 9:04 a.m.
Let's move the definition of note into the if body here. No reason to fetch the value if we're not …	david	Sept. 22, 2022, 9:06 a.m.
Can you add a trailing comma here?	david	Sept. 22, 2022, 9:06 a.m.

flake8 passed.

JSHint passed.

Summary:

-	Fix bugs on API tokens config page.
+	Fix bugs in the API tokens config page.

Commits:

	Summary
-	Fix bugs on API tokens config page.
+	Fix bugs on API tokens config page.

Diff:

Revision 2 (+58 -28)

Show changes

reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Show all issues
```
Typo in description: woudl -> would
```

reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js (Diff revision 2)

Show all issues

In this case, we'll alert but then continue on below and try to save with an undefined policy. Seems like we should probably just return here.

reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js (Diff revision 2)

Show all issues

Let's move the definition of note into the if body here. No reason to fetch the value if we're not going to do anything with it.

reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js (Diff revision 2)
Show all issues
```
Can you add a trailing comma here?
```

Description:

		While testing the new token expiration controls on the API tokens page, it was
		discovered that the displayed expiration date would revert to an old value
		whenever the policy type changed. To fix this, we update the displayed
		expiration date whenever its value changes and whenever the token's information
		is rendered.

		This change also fixes two bugs related to the custom policy editor. The first
		being that you couldn't set custom policies due to an out of scope variable.
~		Secondly, canceling out of the custom policy editor woudl sometimes revert to
~		the wrong value. This would happen when for tokens that currently have a custom
	~	Secondly, canceling out of the custom policy editor would sometimes revert to
	~	the wrong value. This would happen for tokens that currently have a custom
		policy set.