Summary

Limit SAML support to Python <= 3.10

Review Request #12592 — Created Sept. 12, 2022 and submitted Sept. 13, 2022, 3:06 p.m.

Information

Owner

maubin

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The python3-saml in our SAML dependencies requires lxml < 4.7.1, however this
fails to compile on Python 3.11. This change skips the SAML dependencies when
setting up for Python 3.11.

Testing Done

Ran python3.11 ./setup.py develop successfully.

Commits

Summary	ID
Limit SAML support to Python <=3.10	cdbf26d1657c855648ccce7dfb43fcac84b3c825
mend	d00d54047d9fc5abaef5c5cc28eec97ffd4bf4af

Issues

Description	From	Last Updated
There's a trailing space and a missing period. Can you add a space around the </<= operators throughout the comment?	chipx86	Sept. 13, 2022, 9:35 a.m.

flake8 passed.

JSHint passed.

dev-requirements.txt (Diff revision 1)

The issue has been resolved. Show all issues

There's a trailing space and a missing period.
Can you add a space around the </<= operators throughout the comment?

Change Summary:

Add space around the < and <= operators.

Summary:

-	Limit SAML support to Python <=3.10
+	Limit SAML support to Python <= 3.10

Description:

~		The `python3-saml` in our SAML dependencies requires `lxml<4.7.1`, however this
	~	The `python3-saml` in our SAML dependencies requires `lxml < 4.7.1`, however this
		fails to compile on Python 3.11. This change skips the SAML dependencies when
		setting up for Python 3.11.

Commits:

	Summary	ID
	Limit SAML support to Python <=3.10	cdbf26d1657c855648ccce7dfb43fcac84b3c825
	mend	2cf466db711072900538383982da91c52223a9b8
	Limit SAML support to Python <=3.10	cdbf26d1657c855648ccce7dfb43fcac84b3c825
	mend	d00d54047d9fc5abaef5c5cc28eec97ffd4bf4af

Diff:

Revision 2 (+13 -5)

Show changes

dev-requirements.txt

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (3ed43a6)