Limit SAML support to Python <= 3.10
Review Request #12592 — Created Sept. 12, 2022 and submitted
The
python3-saml
in our SAML dependencies requireslxml < 4.7.1
, however this
fails to compile on Python 3.11. This change skips the SAML dependencies when
setting up for Python 3.11.
Ran
python3.11 ./setup.py develop
successfully.
Summary | ID |
---|---|
cdbf26d1657c855648ccce7dfb43fcac84b3c825 | |
d00d54047d9fc5abaef5c5cc28eec97ffd4bf4af |
Description | From | Last Updated |
---|---|---|
There's a trailing space and a missing period. Can you add a space around the </<= operators throughout the comment? |
|
![maubin](https://media-reviews-reviewboard-org.s3.amazonaws.com/uploaded/avatars/m/ma/maubin__28892f51-5581-4db1-b65d-322d3b6117de.jpg?AWSAccessKeyId=AKIAJXEP4CRSJE2AMHOQ&Signature=fEZFUHPqd%2FUSZuGkqDHAaErZoWg%3D&Expires=1722042295)
- Change Summary:
-
Add space around the
<
and<=
operators. - Summary:
-
Limit SAML support to Python <=3.10Limit SAML support to Python <= 3.10
- Description:
-
~ The
python3-saml
in our SAML dependencies requireslxml<4.7.1
, however this~ The
python3-saml
in our SAML dependencies requireslxml < 4.7.1
, however thisfails to compile on Python 3.11. This change skips the SAML dependencies when setting up for Python 3.11. - Commits:
-
Summary ID cdbf26d1657c855648ccce7dfb43fcac84b3c825 2cf466db711072900538383982da91c52223a9b8 cdbf26d1657c855648ccce7dfb43fcac84b3c825 d00d54047d9fc5abaef5c5cc28eec97ffd4bf4af - Diff:
-
Revision 2 (+13 -5)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.