Update the Mercurial unit tests to use build_client() and clean up tests.
Review Request #12508 — Created Aug. 5, 2022 and submitted — Latest diff uploaded
This updates the Mercurial unit tests to build a
each test where it's needed, rather than in
setUp(). This is in
prepration for new tests that will need to handle client construction
This also cleans up a lot of the assertions to be less verbose and to be
We had a lot of combinations of checking instance type, key presence,
and then values, but this is far less useful (less accurate) than just
checking dictionaries for equality. We missed things because we weren't
doing these checks.
Given the work being done already in each function, I felt this was the
best time to clean this code up. It's caught some missing state we
Mercurial unit tests pass.