Summary

Update the Mercurial unit tests to use build_client() and clean up tests.

Review Request #12508 — Created Aug. 5, 2022 and submitted Aug. 14, 2022, 7:53 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This updates the Mercurial unit tests to build a MercurialClient in
each test where it's needed, rather than in setUp(). This is in
prepration for new tests that will need to handle client construction
differently.

This also cleans up a lot of the assertions to be less verbose and to be
more comprehensive.

We had a lot of combinations of checking instance type, key presence,
and then values, but this is far less useful (less accurate) than just
checking dictionaries for equality. We missed things because we weren't
doing these checks.

Given the work being done already in each function, I felt this was the
best time to clean this code up. It's caught some missing state we
weren't checking.

Testing Done

Mercurial unit tests pass.

Commits

Summary	ID
Update the Mercurial unit tests to use build_client() and clean up tests. This updates the Mercurial unit tests to build a `MercurialClient` in each test where it's needed, rather than in `setUp()`. This is in prepration for new tests that will need to handle client construction differently. This also cleans up a lot of the assertions to be less verbose and to be more comprehensive. We had a lot of combinations of checking instance type, key presence, and then values, but this is far less useful (less accurate) than just checking dictionaries for equality. We missed things because we weren't doing these checks. Given the work being done already in each function, I felt this was the best time to clean this code up. It's caught some missing state we weren't checking.	597657ccec6f6de6fa3e3679a826de89238a4c78

Summary

Update the Mercurial unit tests to use build_client() and clean up tests.

This updates the Mercurial unit tests to build a `MercurialClient` in each test where it's needed, rather than in `setUp()`. This is in prepration for new tests that will need to handle client construction differently. This also cleans up a lot of the assertions to be less verbose and to be more comprehensive. We had a lot of combinations of checking instance type, key presence, and then values, but this is far less useful (less accurate) than just checking dictionaries for equality. We missed things because we weren't doing these checks. Given the work being done already in each function, I felt this was the best time to clean this code up. It's caught some missing state we weren't checking.

597657ccec6f6de6fa3e3679a826de89238a4c78

flake8 passed.

JSHint passed.

Change Summary:

Updated to target RBTools 4.0.

Commits:

	Summary	ID
	Update the Mercurial unit tests to use build_client() and clean up tests. This updates the Mercurial unit tests to build a `MercurialClient` in each test where it's needed, rather than in `setUp()`. This is in prepration for new tests that will need to handle client construction differently. This also cleans up a lot of the assertions to be less verbose and to be more comprehensive. We had a lot of combinations of checking instance type, key presence, and then values, but this is far less useful (less accurate) than just checking dictionaries for equality. We missed things because we weren't doing these checks. Given the work being done already in each function, I felt this was the best time to clean this code up. It's caught some missing state we weren't checking.	51850ae596552af1f3c50367ebfa7e19b0d422cc
	Update the Mercurial unit tests to use build_client() and clean up tests. This updates the Mercurial unit tests to build a `MercurialClient` in each test where it's needed, rather than in `setUp()`. This is in prepration for new tests that will need to handle client construction differently. This also cleans up a lot of the assertions to be less verbose and to be more comprehensive. We had a lot of combinations of checking instance type, key presence, and then values, but this is far less useful (less accurate) than just checking dictionaries for equality. We missed things because we weren't doing these checks. Given the work being done already in each function, I felt this was the best time to clean this code up. It's caught some missing state we weren't checking.	597657ccec6f6de6fa3e3679a826de89238a4c78

Branch:

release-3.x

release-4.x

Diff:

Revision 2 (+886 -636)

Show changes

rbtools/clients/tests/test_mercurial.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.x (9866ceb)