FIX: pseudo-terminal returning width=0 causes crash in rbsite

 






 

 


  Review Request #12464
  —
  Created July 12, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  Werner
 









 
 

  Review Board
 









 
 

  release-4.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
When running on a pseudo-terminal (such as in a NAS), get_terminal_size() could return (0,0).


In rbsite.py, line 2527 the terminal width is retrieved, then subtracted by 4, resulting in a negative wrap_width which causes a crash in line 2535, in textwrap.fill().

 








  


 
 

  
By hand, on a Synology DiskStation DS220+, with RB 4.0.7 running in a Docker container.

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     FIX: pseudo-terminal returning width=0 causes crash in rbsite
     
When running on a pseudo-terminal (such as in a NAS), get_terminal_size()
can return (0,0) which is not handled correctly.

    

   
  		
  d49a46402ab154a388c7d4932702e0bd71132979
  Werner Damman
 


 
  
 
 
  
   
    
Refactored, avoid duplicating magic number

   
  		
  25eb9e578b83b7bc588de0c104a7034059a2e76f
  Werner Damman
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/cmdline/utils/console.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...