Summary:

FIX: pseudo-terminal returning width=0 causes crash in rbsite

Review Request #12464 — Created July 12, 2022 and submitted Sept. 26, 2022, 1:36 a.m.

Information
Owner:	Werner
Repository:	Review Board
Branch:	release-4.0.x
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

When running on a pseudo-terminal (such as in a NAS), get_terminal_size() could return (0,0).
In rbsite.py, line 2527 the terminal width is retrieved, then subtracted by 4, resulting in a negative wrap_width which causes a crash in line 2535, in textwrap.fill().

Testing Done

By hand, on a Synology DiskStation DS220+, with RB 4.0.7 running in a Docker container.

Commits

Summary
	FIX: pseudo-terminal returning width=0 causes crash in rbsite
	Refactored, avoid duplicating magic number

Screenshots

Issues

Description	From	Last Updated
Rather than re-introduce the magic number of 79, this can be: term_width = shutil.get_terminal_size()[0] or term_width	chipx86	July 12, 2022, 11:44 p.m.

flake8 passed.

JSHint passed.

```
Thanks for the contribution!
```

reviewboard/cmdline/utils/console.py (Diff revision 1)

Show all issues

Rather than re-introduce the magic number of 79, this can be:

term_width = shutil.get_terminal_size()[0] or term_width

Commits:

	Summary
-		FIX: pseudo-terminal returning width=0 causes crash in rbsite
+		FIX: pseudo-terminal returning width=0 causes crash in rbsite
+		Refactored, avoid duplicating magic number

Diff:

Revision 2 (+5 -3)

Show changes

reviewboard/cmdline/utils/console.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (f0984e4)