flake8
passed.
JSHint
passed.
Review Request #12464 — Created July 12, 2022 and submitted
Information | |
---|---|
Werner | |
Review Board | |
release-4.0.x | |
Reviewers | |
reviewboard | |
When running on a pseudo-terminal (such as in a NAS), get_terminal_size() could return (0,0).
In rbsite.py, line 2527 the terminal width is retrieved, then subtracted by 4, resulting in a negative wrap_width which causes a crash in line 2535, in textwrap.fill().
By hand, on a Synology DiskStation DS220+, with RB 4.0.7 running in a Docker container.
Summary | |
---|---|
Description | From | Last Updated |
---|---|---|
Rather than re-introduce the magic number of 79, this can be: term_width = shutil.get_terminal_size()[0] or term_width |
|
reviewboard/cmdline/utils/console.py (Diff revision 1) |
---|
Rather than re-introduce the magic number of
79
, this can be:term_width = shutil.get_terminal_size()[0] or term_width
Commits: |
|
||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+5 -3) |