FIX: pseudo-terminal returning width=0 causes crash in rbsite

Review Request #12464 — Created July 12, 2022 and submitted — Latest diff uploaded

Information

Review Board
release-4.0.x

Reviewers

When running on a pseudo-terminal (such as in a NAS), get_terminal_size() could return (0,0).

In rbsite.py, line 2527 the terminal width is retrieved, then subtracted by 4, resulting in a negative wrap_width which causes a crash in line 2535, in textwrap.fill().

By hand, on a Synology DiskStation DS220+, with RB 4.0.7 running in a Docker container.

Commits

Files

    Loading...