Sonar dependency update, round 2.




 


  Review Request #12447
  —
  Created July 8, 2022 and submitted 

 















 
  
  
 






 
  

   Information

  

 
 

  

   
   
david


  


  

   
   
student-sonar


  


  

   
   
master


  


  

   
   



  


  

   
   



  


 



 
  

   Reviewers

  

 
 

  

   
   
student-sonar


  


  

   
   



  


 











 

  
  


This is the second phase of updating sonar's dependencies. Many of these

ones are focused more on the frontend side of things, including updating

to newer versions of react.


This also switches us over to using the "module" type in package.json.

This tells node that we're operating using ES6 modules rather than

CommonJS imports. This eliminates the need to use babel-node, which

simplifies things considerably and should improve performance a lot. The

one casualty of this is the newrelic integration, which would need

external configuration (since apparently the newrelic.js file can't be

loaded in ESM mode). I don't really care about newrelic monitoring here,

so this is fine for now.


I've also deleted the old load-old-data.js script. This was used when

we moved the data storage over from MongoDB to SQL, but isn't necessary

anymore.




 




 

  
  


Logged in and checked various features. In particular, tested parts of

the UI affected by the selectize update (things like group membership

selectors), and React-MDE (the status report markdown editor).




 












 

  
  





 

   

   

 
 
  

    Summary

  

 
 

  


   

    
     
    

   

   
Sonar dependency update, round 2.


  


 






 




 

 






 
 
 

  

   

    
   

   
    
    
  • 
     
    
    • 
    
  • 
     
    
    • 
    
  • 
     
    
    • 
    
  • 
     
    
    • 
    
  • 
     
    
    • 
   

  

  

   
    

     Description
     From
     Last Updated
    

   
   



    

     
      
      
'fs' is defined but never used. Column: 8 Error code: W098

     		
     
      reviewbotreviewbot
     
     
      
     
    




    

     
      
      
'shell' is defined but never used. Column: 8 Error code: W098

     		
     
      reviewbotreviewbot
     
     
      
     
    




    

     
      
      
import.meta may only be used in module code. Column: 40 Error code: E070

     		
     
      reviewbotreviewbot
     
     
      
     
    




    

     
      
      
import.meta may only be used in module code. Column: 40 Error code: E070

     		
     
      reviewbotreviewbot
     
     
      
     
    




    

     
      
      
import.meta may only be used in module code. Column: 40 Error code: E070

     		
     
      reviewbotreviewbot
     
     
      
     
    




    

     
      
      
import.meta may only be used in module code. Column: 40 Error code: E070

     		
     
      reviewbotreviewbot
     
     
      
     
    


   
  

 












  

 



















 




 

  


   

   

    
 
Checks run (1 failed, 1 succeeded)


    
   


  

  

  





 

 flake8
 passed.
 





 

 JSHint
 failed.
 
















 
JSHint

 


 







  

 





 














 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  











 



  

   
Commits:

   
    



 

  
    

    

    

  
  
   

    
    Summary

  

  

   

    -

     

      
       
      

     

    
Sonar dependency update, round 2.


   



   

    +

     

      
       
      

     

     
Sonar dependency update, round 2.


   


  
 




   		
  




  

   
Diff:

   
    
 Revision 2 (+1892 -5162)
Show changes
 
    gulpfile.js 
    newrelic.js 
    package.json 
    package-lock.json 
    server.js 
    webpack.config.js 
    bin/load-old-data.js 
    bin/load-slack-users.js 
  15 more
 

   		
  



 









 

  
Checks run (1 failed, 1 succeeded)



  

 flake8
 passed.
 





  

 JSHint
 failed.
 





 










 
JSHint

 


 












  

 
















 





 

  

   




maubin




   

   







  

 



 

  


   

   

    
 
maubin


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to master (0cebb0c)





 


 










  

 









     

    

   

  

  

   
   Loading...