Summary

Sonar dependency update, round 2.

Review Request #12447 — Created July 8, 2022 and submitted July 12, 2022, 9:07 a.m.

Information

Owner

david

Repository

student-sonar

Branch

master

Bugs

Depends On

Reviewers

Groups

student-sonar

People

Description

This is the second phase of updating sonar's dependencies. Many of these
ones are focused more on the frontend side of things, including updating
to newer versions of react.

This also switches us over to using the "module" type in package.json.
This tells node that we're operating using ES6 modules rather than
CommonJS imports. This eliminates the need to use babel-node, which
simplifies things considerably and should improve performance a lot. The
one casualty of this is the newrelic integration, which would need
external configuration (since apparently the newrelic.js file can't be
loaded in ESM mode). I don't really care about newrelic monitoring here,
so this is fine for now.

I've also deleted the old load-old-data.js script. This was used when
we moved the data storage over from MongoDB to SQL, but isn't necessary
anymore.

Testing Done

Logged in and checked various features. In particular, tested parts of
the UI affected by the selectize update (things like group membership
selectors), and React-MDE (the status report markdown editor).

Commits

Summary	ID
Sonar dependency update, round 2. This is the second phase of updating sonar's dependencies. Many of these ones are focused more on the frontend side of things, including updating to newer versions of react. This also switches us over to using the "module" type in `package.json`. This tells node that we're operating using ES6 modules rather than CommonJS imports. This eliminates the need to use babel-node, which simplifies things considerably and should improve performance a lot. The one casualty of this is the newrelic integration, which would need external configuration (since apparently the `newrelic.js` file can't be loaded in ESM mode). I don't really care about newrelic monitoring here, so this is fine for now. I've also deleted the old `load-old-data.js` script. This was used when we moved the data storage over from MongoDB to SQL, but isn't necessary anymore. Testing Done: Logged in and checked various features. In particular, tested parts of the UI affected by the selectize update (things like group membership selectors), and React-MDE (the status report markdown editor).	837babca70e1fe9bb00577cbc18668f4667868e0

Summary

Sonar dependency update, round 2.

This is the second phase of updating sonar's dependencies. Many of these ones are focused more on the frontend side of things, including updating to newer versions of react. This also switches us over to using the "module" type in `package.json`. This tells node that we're operating using ES6 modules rather than CommonJS imports. This eliminates the need to use babel-node, which simplifies things considerably and should improve performance a lot. The one casualty of this is the newrelic integration, which would need external configuration (since apparently the `newrelic.js` file can't be loaded in ESM mode). I don't really care about newrelic monitoring here, so this is fine for now. I've also deleted the old `load-old-data.js` script. This was used when we moved the data storage over from MongoDB to SQL, but isn't necessary anymore. Testing Done: Logged in and checked various features. In particular, tested parts of the UI affected by the selectize update (things like group membership selectors), and React-MDE (the status report markdown editor).

837babca70e1fe9bb00577cbc18668f4667868e0

Issues

Description	From	Last Updated
'fs' is defined but never used. Column: 8 Error code: W098	reviewbot	July 8, 2022, 3:12 p.m.
'shell' is defined but never used. Column: 8 Error code: W098	reviewbot	July 8, 2022, 3:12 p.m.
import.meta may only be used in module code. Column: 40 Error code: E070	reviewbot	July 8, 2022, 3:12 p.m.
import.meta may only be used in module code. Column: 40 Error code: E070	reviewbot	July 8, 2022, 3:12 p.m.
import.meta may only be used in module code. Column: 40 Error code: E070	reviewbot	July 8, 2022, 3:13 p.m.
import.meta may only be used in module code. Column: 40 Error code: E070	reviewbot	July 8, 2022, 3:13 p.m.

flake8 passed.

JSHint failed.

JSHint

gulpfile.js (Diff revision 1)
The issue has been dropped. Show all issues
```
'fs' is defined but never used.

Column: 8
Error code: W098
```

gulpfile.js (Diff revision 1)

The issue has been dropped. Show all issues

'shell' is defined but never used.

Column: 8
Error code: W098

lib/api.js (Diff revision 1)

The issue has been dropped. Show all issues

import.meta may only be used in module code.

Column: 40
Error code: E070

webpack.config.js (Diff revision 1)

The issue has been dropped. Show all issues

import.meta may only be used in module code.

Column: 40
Error code: E070

Commits:

	Summary	ID
	Sonar dependency update, round 2. This is the second phase of updating sonar's dependencies. Many of these ones are focused more on the frontend side of things, including updating to newer versions of react. This also switches us over to using the "module" type in `package.json`. This tells node that we're operating using ES6 modules rather than CommonJS imports. This eliminates the need to use babel-node, which simplifies things considerably and should improve performance a lot. The one casualty of this is the newrelic integration, which would need external configuration (since apparently the `newrelic.js` file can't be loaded in ESM mode). I don't really care about newrelic monitoring here, so this is fine for now. I've also deleted the old `load-old-data.js` script. This was used when we moved the data storage over from MongoDB to SQL, but isn't necessary anymore. Testing Done: Logged in and checked various features. In particular, tested parts of the UI affected by the selectize update (things like group membership selectors), and React-MDE (the status report markdown editor).	c4015367215171554f6139b54f6c4c2a4944b489
	Sonar dependency update, round 2. This is the second phase of updating sonar's dependencies. Many of these ones are focused more on the frontend side of things, including updating to newer versions of react. This also switches us over to using the "module" type in `package.json`. This tells node that we're operating using ES6 modules rather than CommonJS imports. This eliminates the need to use babel-node, which simplifies things considerably and should improve performance a lot. The one casualty of this is the newrelic integration, which would need external configuration (since apparently the `newrelic.js` file can't be loaded in ESM mode). I don't really care about newrelic monitoring here, so this is fine for now. I've also deleted the old `load-old-data.js` script. This was used when we moved the data storage over from MongoDB to SQL, but isn't necessary anymore. Testing Done: Logged in and checked various features. In particular, tested parts of the UI affected by the selectize update (things like group membership selectors), and React-MDE (the status report markdown editor).	837babca70e1fe9bb00577cbc18668f4667868e0

Diff:

Revision 2 (+1892 -5162)

Show changes

	gulpfile.js
	newrelic.js
	package.json
	package-lock.json
	server.js
	webpack.config.js
	bin/load-old-data.js
	bin/load-slack-users.js
	15 more

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

lib/api.js (Diff revision 2)

The issue has been dropped. Show all issues

import.meta may only be used in module code.

Column: 40
Error code: E070

webpack.config.js (Diff revision 2)

The issue has been dropped. Show all issues

import.meta may only be used in module code.

Column: 40
Error code: E070

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (0cebb0c)