Added automated flag when closing or editing review requests

 






 

 


  Review Request #12051
  —
  Created Feb. 10, 2022 and updated  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  sheenaNg
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  12038
 









 
 

  12223
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
    

  • Added automated flag to multiple methods related to hostingsvcs close 
    
hook, ReviewRequestResourceAPI Update(), and review_request.close() 
    
to store the value in ChangeDescription model to track automated 
    
closing of review requests 
    • 





    

  • Added automated flag to 
    
ReviewRequestResourceDraftAPI Update(), Create(), 
    
review_request.publish(), draft.publish() to store the value in
    
ChangeDescription model to track automated upddating/publishing 
    
of review requests 
    • 





    

  • Added automated flag to closed/published signals and email-related methods to render the 
    
review_request_email.txt differently when automated=True 
    • 





    

  • Added codes to change.html template to render RB logo in the 
    
review request change entry when automated=True
    • 


 








  


 
 

  
    

  • Added unit tests to test_email_sending.py
    • 

  • Added unit tests to test_review_request.py
    • 

  • Added unit tests to test_review_request_draft.py
    • 

  • Added unit tests to test_entries.py
    • 

  • Added unit tests to webapi/tests/test_review_request.py
    • 

  • Added unit tests to webapi/tests/test_review_request_draft.py
    • 

  • Added assertion to test_github.py, test_rbgateway.py, 
    
test_bitbucket.py
    • 



All tests passed. 


    

  • Attached screenshots to show changes in close email .txt and 
    
frontend changeEntry.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 9 and 10



    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9
10

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    
Added isAutomatedClose flag through close hook flow to ChangeDescription's ex...

   
  		
  7602ec39197a73225f8745aff3cd31719ce5b613
  sng06
 


 
  
 
 
  
   
    
Deleted print statements in unit tests

   
  		
  5c80bafbbf2de23d24c63d689f687a71d8a7fe72
  sng06
 


 
  
 
 
  
   
    
Changed variable name to automate

   
  		
  872111ef847893732f11a7da42a050ea83df365e
  sng06
 


 
  
 
 
  
   
    
Added automate field to ReviewRequestResource API update method and passed it...

   
  		
  db297a5f73113abb152fa29217772cc66e8a3064
  sng06
 


 
  
 
 
  
   
    
Added automate fields and made changes to  email-related methods based on aut...

   
  		
  c3373843b683d9585c8214752943176547cfc81d
  sng06
 


 
  
 
 
  
   
    
Made changes to close email txt template based on automate flag value

   
  		
  09982b5c4da28428a9a4b0adc77df1b91e13ecec
  sng06
 


 
  
 
 
  
   
    
Added unit tests to review_request and test_email_sending test suites

   
  		
  db179bc452fbaad6ae9172762b6418269209da41
  sng06
 


 
  
 
 
  
   
    
Added default value to automate argument in close_review_request method

   
  		
  2510eea77446702450a41d9bbd0f52d4121aa025
  sng06
 


 
  
 
 
  
   
    
Changed assertEqual to assertTrue for test_post_commit_hook unit test

   
  		
  e3aa17a75338f49aa54d15ad63c882b7f405f0b8
  sng06
 


 
  
 
 
  
   
    
Added optional for automate field in docstrings

   
  		
  8a09a22cbdeab482feed8d25701f6394b068f250
  sng06
 


 
  
 
 
  
   
    
Fixed review_request_close unit test spy assertion

   
  		
  b62fb1873502ab686e565d6ace6d3b277df7cfd7
  sng06
 


 
  
 
 
  
   
    
Added codes to render Review Board logo in review request change box when it ...

   
  		
  61707b3761207f8c90b1d974a12869dfb095f783
  sng06
 


 
  
 
 
  
   
    
Added or edited docstrings and fixed formatting issues

   
  		
  6261eea6c3151e19473125392c675b12085e18b6
  sng06
 


 
  
 
 
  
   
    
Added class tag to RB logo avatar rendering in change.html template

   
  		
  e7ece132d43385ca92e2eaa039b80005769ba846
  sng06
 


 
  
 
 
  
   
    
Added unit tests to test changeEntry

   
  		
  912ad653f5bcd3a2392c19705713a44ae6909c0a
  sng06
 


 
  
 
 
  
   
    
Added automate field to webapi-request-fields decorator for both create and u...

   
  		
  a1a457d17ec6011b13d612e0170137aec579ffcd
  sng06
 


 
  
 
 
  
   
    
added unit tests to test PUT api for submitted and discarded actions

   
  		
  3669f17735fdc99ec5bb3d1e48b8aac098cb6593
  sng06
 


 
  
 
 
  
   
    
Deleted print statements

   
  		
  c101d5b96306e8331a962252013f871b8f4b726b
  sng06
 


 
  
 
 
  
   
    
Edited automate field's description

   
  		
  a58040644fe80ca26811a6657017046a125d3e97
  sng06
 


 
  
 
 
  
   
    
Added automate field to draft resource PUT endpoint, review request publish-r...

   
  		
  d04c52201d0d41496292d041143c9cca639b6f3e
  sng06
 


 
  
 
 
  
   
    
Fixed formatting and added docstring

   
  		
  1b8ab351a8b812a6f8e2e44d514bf3697f0db3c1
  sng06
 


 
  
 
 
  
   
    
Added unit tests to test draft-related methods

   
  		
  bd4cdabc44ab04e80908622365e979894f4f9ebb
  sng06
 


 
  
 
 
  
   
    
Changed review_request close unit test name

   
  		
  71e86af411377ffefbf4b5257fd07b7856788b22
  sng06
 


 
  
 
 
  
   
    
Changed automate to automated and edited unit tests docstrings

   
  		
  4484e5811f93262a3cf393b05b6336046eb09aef
  sng06
 


 
  
 
 
  
   
    
Fixed review request draft unit tests docstrings

   
  		
  394eb6ffbc2b5ff720ed704eff0693daf74c170b
  sng06
 


 
  
 
 
  
   
    
Changed the conditional block to save automated value in extra context using ...

   
  		
  428422a748e222da03859a461d82c65bcbf369e0
  sng06
 


 
  
 
 
  
   
    
Fixed formatting issues in review_request and review_request_draft unit tests

   
  		
  11ac18e034e3d3c45fe5e7597c1c8baa4e78b6b7
  sng06
 


 
  
 
 
  
   
    
Fixed missing words and periods in docstrings

   
  		
  7b2b51eae67be14929f128763de6c9754050b969
  sng06
 


 
  
 
 
  
   
    
Added isAutomatedClose flag through close hook flow to ChangeDescription's ex...

   
  		
  ae08fb83f5c61aee389a3cbdcc9ffc8bf86b1c2d
  sng06
 


 
  
 
 
  
   
    
Deleted print statements in unit tests

   
  		
  379f610ef9fd8101e95f0e3e1b4f6dac08306e22
  sng06
 


 
  
 
 
  
   
    
Changed variable name to automate

   
  		
  e0fb128a7626a118246c6e5719ba188d810ba775
  sng06
 


 
  
 
 
  
   
    
Added automate field to ReviewRequestResource API update method and passed it...

   
  		
  1c3661f9ea9e0ba1fd4364ac3bc273569db33d37
  sng06
 


 
  
 
 
  
   
    
Added automate fields and made changes to  email-related methods based on aut...

   
  		
  672e3f66657b5ab3fc7dc722b5fbdea25a234989
  sng06
 


 
  
 
 
  
   
    
Made changes to close email txt template based on automate flag value

   
  		
  730f9b695f6f425e6a51ff68eb9093e0b75dc240
  sng06
 


 
  
 
 
  
   
    
Added unit tests to review_request and test_email_sending test suites

   
  		
  b51528501757f139255fecd65b1ef1d5a580e728
  sng06
 


 
  
 
 
  
   
    
Added default value to automate argument in close_review_request method

   
  		
  e4d4befa081b860ae9778c85eab621a013b663f9
  sng06
 


 
  
 
 
  
   
    
Changed assertEqual to assertTrue for test_post_commit_hook unit test

   
  		
  7f060eec71a71aafc213cf695f5c01a6e58d970a
  sng06
 


 
  
 
 
  
   
    
Added optional for automate field in docstrings

   
  		
  fedbc56e20bc730ac7d7c22488b272250d334e1a
  sng06
 


 
  
 
 
  
   
    
Fixed review_request_close unit test spy assertion

   
  		
  a76d6541b60e60860319bec47a668a1534824524
  sng06
 


 
  
 
 
  
   
    
Added codes to render Review Board logo in review request change box when it ...

   
  		
  4c41ae5c1a003d287b178960b873f8c2b188e73e
  sng06
 


 
  
 
 
  
   
    
Added or edited docstrings and fixed formatting issues

   
  		
  b9eee8455a0b69fb818ee37643a83cabeb4d5ed6
  sng06
 


 
  
 
 
  
   
    
Added class tag to RB logo avatar rendering in change.html template

   
  		
  de8085943180d5a6a1c9580f9a3cc27d75f8bcc2
  sng06
 


 
  
 
 
  
   
    
Added unit tests to test changeEntry

   
  		
  8c8a72124aef4a479f15a8da8c413f42f929ba5f
  sng06
 


 
  
 
 
  
   
    
Added automate field to webapi-request-fields decorator for both create and u...

   
  		
  77d8a9ac58eb1c1fe331080b25d4407baf822a0f
  sng06
 


 
  
 
 
  
   
    
added unit tests to test PUT api for submitted and discarded actions

   
  		
  cfaf73b88ed49e03a7895530f1dc1d05d0ef1ebc
  sng06
 


 
  
 
 
  
   
    
Deleted print statements

   
  		
  5ca764de4cc3f8e43301b3f20e61393350922742
  sng06
 


 
  
 
 
  
   
    
Edited automate field's description

   
  		
  0a6178d4e8bb5b1211c8ff518bb01a2b730f13d8
  sng06
 


 
  
 
 
  
   
    
Added automate field to draft resource PUT endpoint, review request publish-r...

   
  		
  7bc2c4d53dc7715e2e5f81c46a3942585efa61dd
  sng06
 


 
  
 
 
  
   
    
Fixed formatting and added docstring

   
  		
  7a0dd7e5491153465a7c79f5557b3be8fd40d346
  sng06
 


 
  
 
 
  
   
    
Added unit tests to test draft-related methods

   
  		
  7083cb3ff5115b9173faa39e7076da009d0c52af
  sng06
 


 
  
 
 
  
   
    
Changed review_request close unit test name

   
  		
  c8cb69aa733682714d6c7dc3f5e926523cdeee0a
  sng06
 


 
  
 
 
  
   
    
Changed automate to automated and edited unit tests docstrings

   
  		
  fc9641493757893dc659591ed86786263fbe00bc
  sng06
 


 
  
 
 
  
   
    
Fixed review request draft unit tests docstrings

   
  		
  68e47456666ed949ed78317f8231957a67f0afd7
  sng06
 


 
  
 
 
  
   
    
Changed the conditional block to save automated value in extra context using ...

   
  		
  97e2167d50167344f5dfc41b77651293bbc2edb2
  sng06
 


 
  
 
 
  
   
    
Fixed formatting issues in review_request and review_request_draft unit tests

   
  		
  f95ea9155018cce8da51c570cdf037d1c44c3317
  sng06
 


 
  
 
 
  
   
    
Fixed missing words and periods in docstrings

   
  		
  c34ba1ccffee84b560a925ac2bc90205455ac38b
  sng06
 


 
  
 
 
  
   
    
Addressed code review feedback received

   
  		
  e8f58bbc3333ba3434d31374586344eebc297563
  sng06
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/hostingsvcs/hook_utils.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/notifications/email/message.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/notifications/tests/test_email_sending.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/tests/test_entries.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/tests/test_review_request.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/tests/test_review_request_draft.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...