Added automated_service_info field when closing or editing review requests automatically
Review Request #12223 — Created March 31, 2022 and updated
Information | |
---|---|
sheenaNg | |
Review Board | |
master | |
12051 | |
Reviewers | |
reviewboard | |
Added
automated_service_info
field alongsideautomated
flag to
provide details on the service that updated/closed the review
request automatically.
- Added
automated_service_info
field tohook_utils
,
ReviewRequestResourceAPI Update()
, and
review_request.close()
to store the value in
ChangeDescription model.
- Added
automated_service_info
field to
ReviewRequestResourceDraftAPI Update(), Create()
,
review_request.publish()
,draft.publish()
to store the value
in ChangeDescription model.
- Added
automated_service_info
field to closed/published
signals and email-related methods.
Added unit tests to
test_email_sending.py
Added unit tests totest_review_request.py
Added unit tests totest_review_request_draft.py
Added unit tests towebapi/tests/test_review_request.py
Added unit tests towebapi/tests/test_review_request_draft.py
Added assertion totest_github.py
,test_rbgateway.py
,
test_bitbucket.py
All tests passed.
Summary | Author |
---|---|
sng06 | |
sng06 | |
sng06 | |
sng06 |
Description | From | Last Updated |
---|---|---|
It would be nice if all of the docstrings for functions with automated_service_info arguments described the keys that can be … |
KY kylemclean | |
Instead of defining a variable, let's pass this inline as automated_service_info={'service_name': hosting_service_id} |
|
|
This could potentially be shortened to remove the if statement by utilizing a new variable and the fact that the … |
|
|
This needs a trailing comma. |
|
-
-
reviewboard/notifications/email/message.py (Diff revision 1) This could potentially be shortened to remove the
if
statement by utilizing a new variable and the fact that theget
function defaults toNone
if nothing is found.automated_service_info = extra_data.get('automated_service_info') extra_context.update({ 'automated_service_info': automated_service_info })
-
-
reviewboard/hostingsvcs/hook_utils.py (Diff revision 1) Instead of defining a variable, let's pass this inline as
automated_service_info={'service_name': hosting_service_id}
-
Change Summary:
Addressed code review feedback.
Commits: |
|
|||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+561 -187) |