Created evolution to add extra_data field to ChangeDescription model

Review Request #12038 — Created Feb. 4, 2022 and updated

Information

Review Board
master

Reviewers

Created evolution file to add extra_data JSON field to
ChangeDescription model in order to pass in automate=True flag to
track the originator of the close action when review request is closed
by third-party repo services.

I have run ./manage.py evolve --execute to apply the changes to the
database.

Even though unit test is not required to test for a newly added field,
I did a quick sanity check if the extra_data field is added
successfully to the ChangeDescription model. I have attached the
screenshot to show that.

Summary ID Author
Created evolution to add extra_data field to ChangeDescription model
bdb6a7d48f20b8a37a638ac5fcbaf3f0aaac9a92 sng06
Added module docstring to extra_data evolution file
e7c59310bd103aa5cb4302bba84ace5fdc1a3e41 sng06

Description From Last Updated

You can move the statement about running the evolution into the "testing done" field.

daviddavid

Please wrap your description and testing done to 70 columns for easier readability.

daviddavid

Let's add a module docstring to this (many old files don't have them, but any new files should have it …

daviddavid

Test comment

vilavividavilavivida
sheenaNg
vilavivida
  1. 
      
  2. 
      
vilavivida
  1. 
      
  2. reviewboard/changedescs/models.py (Diff revision 1)
     
     
    Show all issues

    Test comment

    1. Hi, can you explain further what the issue is that I need to fix?

  3. 
      
david
  1. 
      
  2. Show all issues

    You can move the statement about running the evolution into the "testing done" field.

  3. Show all issues

    Please wrap your description and testing done to 70 columns for easier readability.

  4. Show all issues

    Let's add a module docstring to this (many old files don't have them, but any new files should have it as the first line).

    We also won't be needing unicode_literals on master going forward.

  5. 
      
sheenaNg
Review request changed
Change Summary:

Added module docstring to evolution file.

Description:
~  

Created evolution file to add extra_data JSON field to ChangeDescription model in order to pass in automate=True flag to track the originator of the close action when review request is closed by third-party repo services.

~  
~  

I have run ./manage.py evolve --execute to apply the changes to the database.

  ~

Created evolution file to add extra_data JSON field to

  ~ ChangeDescription model in order to pass in automate=True flag to
  ~ track the originator of the close action when review request is closed
  + by third-party repo services.

Testing Done:
~  

Even though unit test is not required to test for a newly added field, I did a quick sanity check if the extra_data field is added successfully to the ChangeDescription model. I have attached the screenshot to show that.

  ~

I have run ./manage.py evolve --execute to apply the changes to the

  + database.

  +
  +

Even though unit test is not required to test for a newly added field,

  + I did a quick sanity check if the extra_data field is added
  + successfully to the ChangeDescription model. I have attached the
  + screenshot to show that.

Commits:
Summary ID Author
Created evolution to add extra_data field to ChangeDescription model
aece120422829fd4afaba9d45f4cc8d3f7f29461 sng06
Created evolution to add extra_data field to ChangeDescription model
bdb6a7d48f20b8a37a638ac5fcbaf3f0aaac9a92 sng06
Added module docstring to extra_data evolution file
e7c59310bd103aa5cb4302bba84ace5fdc1a3e41 sng06

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
david
  1. Looks good to me!

  2.