Added automated flag when closing or editing review requests

 






 

 


  Review Request #12051
  —
  Created Feb. 10, 2022 and updated  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  sheenaNg
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  12038
 









 
 

  12223
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
    

  • Added automated flag to multiple methods related to hostingsvcs close 
    
hook, ReviewRequestResourceAPI Update(), and review_request.close() 
    
to store the value in ChangeDescription model to track automated 
    
closing of review requests 
    • 





    

  • Added automated flag to 
    
ReviewRequestResourceDraftAPI Update(), Create(), 
    
review_request.publish(), draft.publish() to store the value in
    
ChangeDescription model to track automated upddating/publishing 
    
of review requests 
    • 





    

  • Added automated flag to closed/published signals and email-related methods to render the 
    
review_request_email.txt differently when automated=True 
    • 





    

  • Added codes to change.html template to render RB logo in the 
    
review request change entry when automated=True
    • 


 








  


 
 

  
    

  • Added unit tests to test_email_sending.py
    • 

  • Added unit tests to test_review_request.py
    • 

  • Added unit tests to test_review_request_draft.py
    • 

  • Added unit tests to test_entries.py
    • 

  • Added unit tests to webapi/tests/test_review_request.py
    • 

  • Added unit tests to webapi/tests/test_review_request_draft.py
    • 

  • Added assertion to test_github.py, test_rbgateway.py, 
    
test_bitbucket.py
    • 



All tests passed. 


    

  • Attached screenshots to show changes in close email .txt and 
    
frontend changeEntry.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 6 and 7



    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9
10

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    
Added isAutomatedClose flag through close hook flow to ChangeDescription's ex...

   
  		
  15d6fe45b3ce459167df54f7019e3fce9ce5685d
  sng06
 


 
  
 
 
  
   
    
Deleted print statements in unit tests

   
  		
  b8d6558376dfd06da13dfeda8421d5ef33bac926
  sng06
 


 
  
 
 
  
   
    
Changed variable name to automate

   
  		
  8aa66d65c2be8136bc2b43db23c5d10c3dca5ca4
  sng06
 


 
  
 
 
  
   
    
Added automate field to ReviewRequestResource API update method and passed it...

   
  		
  94c874518d9f105f829facb72bde5d5855b959b1
  sng06
 


 
  
 
 
  
   
    
Added automate fields and made changes to  email-related methods based on aut...

   
  		
  6096736f849593d99d88b525f018430e753bcc19
  sng06
 


 
  
 
 
  
   
    
Made changes to close email txt template based on automate flag value

   
  		
  8c254457115746a5bc3f68169f071eb5d59d1498
  sng06
 


 
  
 
 
  
   
    
Added unit tests to review_request and test_email_sending test suites

   
  		
  8ca0e35dd81b36849514a31e10eb6eb02dfc9627
  sng06
 


 
  
 
 
  
   
    
Added default value to automate argument in close_review_request method

   
  		
  80c374d3fbaf65df568a733c181560942fa2f0bc
  sng06
 


 
  
 
 
  
   
    
Changed assertEqual to assertTrue for test_post_commit_hook unit test

   
  		
  7e7061c68d3a6d0828c704597b3089bca76d504c
  sng06
 


 
  
 
 
  
   
    
Added optional for automate field in docstrings

   
  		
  96a34c4d3e87bcbe285e066e0b4e98265ad5bcde
  sng06
 


 
  
 
 
  
   
    
Fixed review_request_close unit test spy assertion

   
  		
  4532790323e090df538f5148e517d52bc1d8c895
  sng06
 


 
  
 
 
  
   
    
Added codes to render Review Board logo in review request change box when it ...

   
  		
  1e8a4fa9780e5f82c76ecf87da3c4f766cc51af0
  sng06
 


 
  
 
 
  
   
    
Added or edited docstrings and fixed formatting issues

   
  		
  3a382f9b42fcb3add8eb77c756e78bee3152f901
  sng06
 


 
  
 
 
  
   
    
Added class tag to RB logo avatar rendering in change.html template

   
  		
  e4c5ad6b3a0a6cf18a5c15058e5f77bee6b6d9ab
  sng06
 


 
  
 
 
  
   
    
Added unit tests to test changeEntry

   
  		
  fe28911e4d1f6eb470e93aab7c68b784aea351d4
  sng06
 


 
  
 
 
  
   
    
Added automate field to webapi-request-fields decorator for both create and u...

   
  		
  797995df7da75c2cdef2d315b1780efd2df84186
  sng06
 


 
  
 
 
  
   
    
added unit tests to test PUT api for submitted and discarded actions

   
  		
  bd5a3f00b096d3579082c6cc09af7b4887b1e523
  sng06
 


 
  
 
 
  
   
    
Deleted print statements

   
  		
  568feed51055cd9b9bc143513a6a9c6cd76b8a16
  sng06
 


 
  
 
 
  
   
    
Edited automate field's description

   
  		
  ec687ac43eb477f5e20374a59c72f839e446e8dc
  sng06
 


 
  
 
 
  
   
    
Added automate field to draft resource PUT endpoint, review request publish-r...

   
  		
  d53d2f7b31dbc98bbcd280076b3b1e9198de26de
  sng06
 


 
  
 
 
  
   
    
Added isAutomatedClose flag through close hook flow to ChangeDescription's ex...

   
  		
  7602ec39197a73225f8745aff3cd31719ce5b613
  sng06
 


 
  
 
 
  
   
    
Deleted print statements in unit tests

   
  		
  5c80bafbbf2de23d24c63d689f687a71d8a7fe72
  sng06
 


 
  
 
 
  
   
    
Changed variable name to automate

   
  		
  872111ef847893732f11a7da42a050ea83df365e
  sng06
 


 
  
 
 
  
   
    
Added automate field to ReviewRequestResource API update method and passed it...

   
  		
  db297a5f73113abb152fa29217772cc66e8a3064
  sng06
 


 
  
 
 
  
   
    
Added automate fields and made changes to  email-related methods based on aut...

   
  		
  c3373843b683d9585c8214752943176547cfc81d
  sng06
 


 
  
 
 
  
   
    
Made changes to close email txt template based on automate flag value

   
  		
  09982b5c4da28428a9a4b0adc77df1b91e13ecec
  sng06
 


 
  
 
 
  
   
    
Added unit tests to review_request and test_email_sending test suites

   
  		
  db179bc452fbaad6ae9172762b6418269209da41
  sng06
 


 
  
 
 
  
   
    
Added default value to automate argument in close_review_request method

   
  		
  2510eea77446702450a41d9bbd0f52d4121aa025
  sng06
 


 
  
 
 
  
   
    
Changed assertEqual to assertTrue for test_post_commit_hook unit test

   
  		
  e3aa17a75338f49aa54d15ad63c882b7f405f0b8
  sng06
 


 
  
 
 
  
   
    
Added optional for automate field in docstrings

   
  		
  8a09a22cbdeab482feed8d25701f6394b068f250
  sng06
 


 
  
 
 
  
   
    
Fixed review_request_close unit test spy assertion

   
  		
  b62fb1873502ab686e565d6ace6d3b277df7cfd7
  sng06
 


 
  
 
 
  
   
    
Added codes to render Review Board logo in review request change box when it ...

   
  		
  61707b3761207f8c90b1d974a12869dfb095f783
  sng06
 


 
  
 
 
  
   
    
Added or edited docstrings and fixed formatting issues

   
  		
  6261eea6c3151e19473125392c675b12085e18b6
  sng06
 


 
  
 
 
  
   
    
Added class tag to RB logo avatar rendering in change.html template

   
  		
  e7ece132d43385ca92e2eaa039b80005769ba846
  sng06
 


 
  
 
 
  
   
    
Added unit tests to test changeEntry

   
  		
  912ad653f5bcd3a2392c19705713a44ae6909c0a
  sng06
 


 
  
 
 
  
   
    
Added automate field to webapi-request-fields decorator for both create and u...

   
  		
  a1a457d17ec6011b13d612e0170137aec579ffcd
  sng06
 


 
  
 
 
  
   
    
added unit tests to test PUT api for submitted and discarded actions

   
  		
  3669f17735fdc99ec5bb3d1e48b8aac098cb6593
  sng06
 


 
  
 
 
  
   
    
Deleted print statements

   
  		
  c101d5b96306e8331a962252013f871b8f4b726b
  sng06
 


 
  
 
 
  
   
    
Edited automate field's description

   
  		
  a58040644fe80ca26811a6657017046a125d3e97
  sng06
 


 
  
 
 
  
   
    
Added automate field to draft resource PUT endpoint, review request publish-r...

   
  		
  d04c52201d0d41496292d041143c9cca639b6f3e
  sng06
 


 
  
 
 
  
   
    
Fixed formatting and added docstring

   
  		
  1b8ab351a8b812a6f8e2e44d514bf3697f0db3c1
  sng06
 


 
  
 
 
  
   
    
Added unit tests to test draft-related methods

   
  		
  bd4cdabc44ab04e80908622365e979894f4f9ebb
  sng06
 


 
  
 
 
  
   
    
Changed review_request close unit test name

   
  		
  71e86af411377ffefbf4b5257fd07b7856788b22
  sng06
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/notifications/tests/test_email_sending.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/signals.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/models/review_request.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/tests/test_entries.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/tests/test_review_request.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/tests/test_review_request_draft.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/review_request.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/tests/test_review_request.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/tests/test_review_request_draft.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...