Summary:

Add a "Last Updated By" column to the dashboard.

Review Request #12018 — Created Jan. 28, 2022 and updated April 7, 2022, 11:05 a.m.

Information
Owner:	kylemclean
Repository:	Review Board
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

These changes add a new column to the review request dashboard called "Last Updated By" which displays the user that made the last update to each review request. Similar to the existing "Last Updated" column, which shows the time that the last update was made, this column is updated whenever a review request is created, edited, receives a review, is closed, or reopened.

Changes

"Last Updated By" column

Added a "Last Updated By" column
Added information about the new column to manual
Added tests for the new column

`ReviewRequest` last activity info functions

ReviewRequest.get_last_activity_info() also returns the user that last updated the review request
Review requests cache their last activity info (last updated object, changedesc, and user) in ReviewRequest.extra_data
Added ReviewRequest.set_last_activity_info(timestamp, updated_object, changedesc, user)
Modified existing uses of ReviewRequest.get_last_activity_info() to take advantage of the user field
Added and modified existing tests of ReviewRequest.get_last_activity_info()

Other

Made the WebAPI ReviewRequestLastUpdateResource return the correct user now that ReviewRequest.get_last_activity_info() includes it

Testing Done


Added tests for the column itself as well as the new last activity-related functions.
Ran all backend tests and observed that all passed.
Performed manual testing of the functionality of the column by creating, editing, reviewing, closing, and reopening review requests and observing how the column changes.

Commits

Summary
	Add a "Last Updated By" column to the dashboard
	First try at optimization of get_last_activity_info
	Continue work on last_activity_info caching
	Fix import error in review_request.py
	Fix incorrect argument order
	None handling for changedesc
	Fetch users in Last Updated By column in one query
	Add LastUpdatedByColumnTests based on UsernameColumnTests
	Fix ReviewRequest.set_last_activity_info() failing when user is None
	Add info on Last Updated By column to dashboard documentation
	Fix issues with review request closing updating last activity info
	Handle user being None in ReviewRequest.get_last_activity_user_id()
	Make ReviewRequest.publish() set updated_object to diffset if it exists
	Update last activity info when review request is reopened
	Fix last_updated being set incorrectly after publishing ReviewRequest
	Send the correct user in ReviewRequestLastUpdateResource
	Fix ReviewRequest.reopen() setting last activity info after no status change
	Make changes to address feedback

Screenshots

Issues

Description	From	Last Updated
E501 line too long (94 > 79 characters)	reviewbot	Feb. 4, 2022, 10:37 p.m.
F401 'reviewboard.diffviewer.models.diffset.DiffSet' imported but unused	reviewbot	Feb. 4, 2022, 10:41 p.m.
F401 'reviewboard.reviews.models.review.Review' imported but unused	reviewbot	Feb. 4, 2022, 10:41 p.m.
E501 line too long (82 > 79 characters)	reviewbot	Feb. 11, 2022, 5:11 p.m.
E501 line too long (94 > 79 characters)	reviewbot	March 11, 2022, 10:19 p.m.
E501 line too long (84 > 79 characters)	reviewbot	March 11, 2022, 10:49 p.m.
E501 line too long (84 > 79 characters)	reviewbot	March 11, 2022, 10:49 p.m.
We need to document the new sortable arg in here.	david	April 7, 2022, 10:57 a.m.
This needs an "Args" section.	david	April 7, 2022, 10:57 a.m.
This needs an "Args" section.	david	April 7, 2022, 10:57 a.m.
We can use a set comprehension here: ids = { review_request.get_last_activity_user_id() for review_request in object_list }	david	April 7, 2022, 10:57 a.m.
You're using this for every test case, so you can just add a class attribute: class LastUpdatedByColumnTests(BaseColumnTestCase): ... fixtures = …	david	April 7, 2022, 10:57 a.m.
Let's wrap this a little differently. Here and in the other test cases below: review_requests = [ self.create_review_request( summary='Test %d' …	david	April 7, 2022, 10:56 a.m.
If Review is used multiple times, wouldn't it be better to move this import statement to the global import at …	sheenaNg	April 10, 2022, 5:51 p.m.
This should be in the imperative mood ("Set" instead of "Sets")	david	April 7, 2022, 10:56 a.m.
Double backticks aren't necessary around the argument names here.	david	April 7, 2022, 10:56 a.m.
The first line of the docstring should be only one line, and should be in the imperative mood. If you …	david	April 7, 2022, 10:56 a.m.
This should be in the imperative mood ("Return" instead of "Returns"). This docstring also needs a "Returns" section.	david	April 7, 2022, 10:56 a.m.
id is a built-in for python. Can we use a different variable name?	david	April 7, 2022, 10:56 a.m.
Add a blank line between these two	david	April 7, 2022, 10:56 a.m.
We generally avoid the python ternary syntax because it's awkward and confusing. Please just use an if/else here.	david	April 7, 2022, 10:56 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/datagrids/columns.py (Diff revision 1)
Show all issues
```
E501 line too long (94 > 79 characters)
```

Commits:

	Summary
-	[WIP] Add a "Last Updated By" column to the dashboard
+	[WIP] Add a "Last Updated By" column to the dashboard
+	[WIP] First try at optimization of get_last_activity_info

Diff:

Revision 2 (+324 -18)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/datagrids/grids.py
	reviewboard/reviews/models/review_request.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/datagrids/columns.py (Diff revision 2)

Show all issues

F401 'reviewboard.diffviewer.models.diffset.DiffSet' imported but unused

reviewboard/datagrids/columns.py (Diff revision 2)

Show all issues

F401 'reviewboard.reviews.models.review.Review' imported but unused

Commits:

	Summary
-	[WIP] Add a "Last Updated By" column to the dashboard
-	[WIP] First try at optimization of get_last_activity_info
+	[WIP] Add a "Last Updated By" column to the dashboard
+	[WIP] First try at optimization of get_last_activity_info

Diff:

Revision 3 (+322 -20)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/datagrids/grids.py
	reviewboard/reviews/models/review_request.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Continue work on last_activity_info caching

Commits:

	Summary
-		[WIP] Add a "Last Updated By" column to the dashboard
-		[WIP] First try at optimization of get_last_activity_info
+		[WIP] Add a "Last Updated By" column to the dashboard
+		[WIP] First try at optimization of get_last_activity_info
+		Continue work on last_activity_info caching

Diff:

Revision 4 (+563 -71)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/datagrids/grids.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	reviewboard/reviews/tests/test_review_request.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/models/review_request.py (Diff revision 4)
Show all issues
```
E501 line too long (82 > 79 characters)
```

Change Summary:

Fetch users in Last Updated By column in one query

Commits:

	Summary
-		[WIP] Add a "Last Updated By" column to the dashboard
-		[WIP] First try at optimization of get_last_activity_info
-		Continue work on last_activity_info caching
+		[WIP] Add a "Last Updated By" column to the dashboard
+		[WIP] First try at optimization of get_last_activity_info
+		Continue work on last_activity_info caching
+		Fix import error in review_request.py
+		Fix incorrect argument order
+		None handling for changedesc
+		Fetch users in Last Updated By column in one query

Diff:

Revision 5 (+2871 -4409)

Show changes

	AUTHORS
	dev-requirements.txt
	contrib/docker/build.py
	docs/releasenotes/4.0.5.rst
	docs/releasenotes/4.0.6.rst
	docs/releasenotes/index.rst
	reviewboard/dependencies.py
	reviewboard/admin/templatetags/rbadmintags.py
	35 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary
-		[WIP] Add a "Last Updated By" column to the dashboard
-		[WIP] First try at optimization of get_last_activity_info
-		Continue work on last_activity_info caching
-		Fix import error in review_request.py
-		Fix incorrect argument order
-		None handling for changedesc
-		Fetch users in Last Updated By column in one query
+		[WIP] Add a "Last Updated By" column to the dashboard
+		[WIP] First try at optimization of get_last_activity_info
+		Continue work on last_activity_info caching
+		Fix import error in review_request.py
+		Fix incorrect argument order
+		None handling for changedesc
+		Fetch users in Last Updated By column in one query

Diff:

Revision 6 (+670 -88)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/datagrids/grids.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	reviewboard/reviews/tests/test_review_request.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Add tests for LastUpdatedByColumn

Commits:

	Summary
-		[WIP] Add a "Last Updated By" column to the dashboard
-		[WIP] First try at optimization of get_last_activity_info
-		Continue work on last_activity_info caching
-		Fix import error in review_request.py
-		Fix incorrect argument order
-		None handling for changedesc
-		Fetch users in Last Updated By column in one query
+		[WIP] Add a "Last Updated By" column to the dashboard
+		[WIP] First try at optimization of get_last_activity_info
+		Continue work on last_activity_info caching
+		Fix import error in review_request.py
+		Fix incorrect argument order
+		None handling for changedesc
+		Fetch users in Last Updated By column in one query
+		Add LastUpdatedByColumnTests based on UsernameColumnTests

Diff:

Revision 7 (+720 -90)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/tests.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	reviewboard/reviews/tests/test_review_request.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/datagrids/tests.py (Diff revision 7)
Show all issues
```
E501 line too long (94 > 79 characters)
```

Commits:

	Summary
-		[WIP] Add a "Last Updated By" column to the dashboard
-		[WIP] First try at optimization of get_last_activity_info
-		Continue work on last_activity_info caching
-		Fix import error in review_request.py
-		Fix incorrect argument order
-		None handling for changedesc
-		Fetch users in Last Updated By column in one query
-		Add LastUpdatedByColumnTests based on UsernameColumnTests
+		[WIP] Add a "Last Updated By" column to the dashboard
+		[WIP] First try at optimization of get_last_activity_info
+		Continue work on last_activity_info caching
+		Fix import error in review_request.py
+		Fix incorrect argument order
+		None handling for changedesc
+		Fetch users in Last Updated By column in one query
+		Add LastUpdatedByColumnTests based on UsernameColumnTests
+		Fix ReviewRequest.set_last_activity_info() failing when user is None

Diff:

Revision 8 (+776 -94)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/tests.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	reviewboard/reviews/tests/test_review_request.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/datagrids/tests.py (Diff revision 8)
Show all issues
```
E501 line too long (84 > 79 characters)
```
reviewboard/datagrids/tests.py (Diff revision 8)
Show all issues
```
E501 line too long (84 > 79 characters)
```

Commits:

	Summary
-		[WIP] Add a "Last Updated By" column to the dashboard
-		[WIP] First try at optimization of get_last_activity_info
-		Continue work on last_activity_info caching
-		Fix import error in review_request.py
-		Fix incorrect argument order
-		None handling for changedesc
-		Fetch users in Last Updated By column in one query
-		Add LastUpdatedByColumnTests based on UsernameColumnTests
-		Fix ReviewRequest.set_last_activity_info() failing when user is None
+		[WIP] Add a "Last Updated By" column to the dashboard
+		[WIP] First try at optimization of get_last_activity_info
+		Continue work on last_activity_info caching
+		Fix import error in review_request.py
+		Fix incorrect argument order
+		None handling for changedesc
+		Fetch users in Last Updated By column in one query
+		Add LastUpdatedByColumnTests based on UsernameColumnTests
+		Fix ReviewRequest.set_last_activity_info() failing when user is None

Diff:

Revision 9 (+780 -94)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/tests.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	reviewboard/reviews/tests/test_review_request.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary
-		[WIP] Add a "Last Updated By" column to the dashboard
-		[WIP] First try at optimization of get_last_activity_info
-		Continue work on last_activity_info caching
-		Fix import error in review_request.py
-		Fix incorrect argument order
-		None handling for changedesc
-		Fetch users in Last Updated By column in one query
-		Add LastUpdatedByColumnTests based on UsernameColumnTests
-		Fix ReviewRequest.set_last_activity_info() failing when user is None
+		[WIP] Add a "Last Updated By" column to the dashboard
+		[WIP] First try at optimization of get_last_activity_info
+		Continue work on last_activity_info caching
+		Fix import error in review_request.py
+		Fix incorrect argument order
+		None handling for changedesc
+		Fetch users in Last Updated By column in one query
+		Add LastUpdatedByColumnTests based on UsernameColumnTests
+		Fix ReviewRequest.set_last_activity_info() failing when user is None
+		Add info on Last Updated By column to dashboard documentation
+		Fix issues with review request closing updating last activity info

Diff:

Revision 10 (+792 -98)

Show changes

	docs/manual/users/dashboard/index.rst
	reviewboard/datagrids/columns.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/tests.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	reviewboard/reviews/tests/test_review_request.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Finished

Summary:

-	[WIP] Add a "Last Updated By" column to the dashboard
+	Add a "Last Updated By" column to the dashboard.

Description:

~		[WIP] Add a "Last Updated By" column to the dashboard
	~	These changes add a new column to the review request dashboard called "Last Updated By" which displays the user that made the last update to each review request.
	+
	+	Changes
	+
	+	"Last Updated By" column
	+
	+	Added a "Last Updated By" column
	+	Added information about the new column to manual
	+	Added tests for the new column
	+
	+	`ReviewRequest` last activity info functions
	+
	+	`ReviewRequest.get_last_activity_info()` also returns the user that last updated the review request
	+	Review requests cache their last activity info (last updated object, changedesc, and user) in `ReviewRequest.extra_data`
	+	Added `ReviewRequest.set_last_activity_info(timestamp, updated_object, changedesc, user)`
	+	Modified existing uses of `ReviewRequest.get_last_activity_info()` to take advantage of the user field
	+	Added and modified existing tests of `ReviewRequest.get_last_activity_info()`
	+
	+	Other
	+
	+	Made the WebAPI `ReviewRequestLastUpdateResource` return the correct user now that `ReviewRequest.get_last_activity_info()` includes it

Testing Done:

	+	Added tests for the column itself as well as the new last activity-related functions.
	+	Ran all backend tests and observed that all passed.
	+	Performed manual testing of the functionality of the column by creating, editing, reviewing, closing, and reopening review requests and observing how the column changes.

Commits:

	Summary
-		[WIP] Add a "Last Updated By" column to the dashboard
-		[WIP] First try at optimization of get_last_activity_info
-		Continue work on last_activity_info caching
-		Fix import error in review_request.py
-		Fix incorrect argument order
-		None handling for changedesc
-		Fetch users in Last Updated By column in one query
-		Add LastUpdatedByColumnTests based on UsernameColumnTests
-		Fix ReviewRequest.set_last_activity_info() failing when user is None
-		Add info on Last Updated By column to dashboard documentation
-		Fix issues with review request closing updating last activity info
+		[WIP] Add a "Last Updated By" column to the dashboard
+		[WIP] First try at optimization of get_last_activity_info
+		Continue work on last_activity_info caching
+		Fix import error in review_request.py
+		Fix incorrect argument order
+		None handling for changedesc
+		Fetch users in Last Updated By column in one query
+		Add LastUpdatedByColumnTests based on UsernameColumnTests
+		Fix ReviewRequest.set_last_activity_info() failing when user is None
+		Add info on Last Updated By column to dashboard documentation
+		Fix issues with review request closing updating last activity info
+		Handle user being None in ReviewRequest.get_last_activity_user_id()
+		Make ReviewRequest.publish() set updated_object to diffset if it exists
+		Update last activity info when review request is reopened
+		Fix last_updated being set incorrectly after publishing ReviewRequest
+		Send the correct user in ReviewRequestLastUpdateResource
+		Fix ReviewRequest.reopen() setting last activity info after no status change

Diff:

Revision 11 (+871 -155)

Show changes

	docs/manual/users/dashboard/index.rst
	reviewboard/datagrids/columns.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/tests.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	reviewboard/reviews/tests/test_review_request.py
	reviewboard/webapi/resources/review_request_last_update.py
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Description:

~		These changes add a new column to the review request dashboard called "Last Updated By" which displays the user that made the last update to each review request.
	~	These changes add a new column to the review request dashboard called "Last Updated By" which displays the user that made the last update to each review request. Similar to the existing "Last Updated" column, which shows the time that the last update was made, this column is updated whenever a review request is created, edited, receives a review, is closed, or reopened.

		Changes

		"Last Updated By" column

		Added a "Last Updated By" column
		Added information about the new column to manual
		Added tests for the new column

		`ReviewRequest` last activity info functions

		`ReviewRequest.get_last_activity_info()` also returns the user that last updated the review request
		Review requests cache their last activity info (last updated object, changedesc, and user) in `ReviewRequest.extra_data`
		Added `ReviewRequest.set_last_activity_info(timestamp, updated_object, changedesc, user)`
		Modified existing uses of `ReviewRequest.get_last_activity_info()` to take advantage of the user field
		Added and modified existing tests of `ReviewRequest.get_last_activity_info()`

		Other

		Made the WebAPI `ReviewRequestLastUpdateResource` return the correct user now that `ReviewRequest.get_last_activity_info()` includes it

reviewboard/datagrids/columns.py (Diff revision 11)

Show all issues

We need to document the new sortable arg in here.

reviewboard/datagrids/columns.py (Diff revision 11)
Show all issues
```
This needs an "Args" section.
```
reviewboard/datagrids/columns.py (Diff revision 11)
Show all issues
```
This needs an "Args" section.
```

reviewboard/datagrids/columns.py (Diff revision 11)

Show all issues

We can use a set comprehension here:

ids = {
    review_request.get_last_activity_user_id()
    for review_request in object_list
}

reviewboard/datagrids/tests.py (Diff revision 11)

Show all issues

You're using this for every test case, so you can just add a class attribute:

class LastUpdatedByColumnTests(BaseColumnTestCase):
    ...
    fixtures = ['test_site']
    ...
    def test_render(self):

reviewboard/datagrids/tests.py (Diff revision 11)

Show all issues

Let's wrap this a little differently. Here and in the other test cases below:

review_requests = [
    self.create_review_request(
        summary='Test %d' % index,
        publish=True,
        submitter=username)
    for (index, username) in enumerate(usernames)
]


In fact, since it looks like you are doing that for all the test methods, perhaps move this into a helper function?

reviewboard/reviews/models/review_request.py (Diff revision 11)
Show all issues
```
This should be in the imperative mood ("Set" instead of "Sets")
```

reviewboard/reviews/models/review_request.py (Diff revision 11)

Show all issues

Double backticks aren't necessary around the argument names here.

reviewboard/reviews/models/review_request.py (Diff revision 11)

Show all issues

The first line of the docstring should be only one line, and should be in the imperative mood. If you need more detail for completenes, add additional paragraphs.

reviewboard/reviews/models/review_request.py (Diff revision 11)

Show all issues

This should be in the imperative mood ("Return" instead of "Returns"). This docstring also needs a "Returns" section.

reviewboard/reviews/models/review_request.py (Diff revision 11)
Show all issues
```
id is a built-in for python. Can we use a different variable name?
```
reviewboard/reviews/models/review_request.py (Diff revision 11)
Show all issues
```
Add a blank line between these two
```

reviewboard/reviews/models/review_request.py (Diff revision 11)

Show all issues

We generally avoid the python ternary syntax because it's awkward and confusing. Please just use an if/else here.

reviewboard/datagrids/columns.py (Diff revision 11)

I wonder why is "state" being passed as a parameter in this method but it is not being used?

kylemclean April 7, 2022, 12:18 a.m.

I decided to add a state argument because the LastUpdatedByColumn, which inherits from UsernameColumn, needs it in this method, and there does not appear to be another way of getting the column state.

reviewboard/reviews/models/review_request.py (Diff revision 11)

Show all issues

If Review is used multiple times, wouldn't it be better to move this import statement to the global import at the top of the file so there is no need to repeat this import statement multiple times?

kylemclean April 7, 2022, 12:18 a.m.

I believe the reason that Review is imported in this method and not the entire module is because it would otherwise result in a circular import between these modules.

Change Summary:

Make changes to address feedback

Commits:

	Summary
-		[WIP] Add a "Last Updated By" column to the dashboard
-		[WIP] First try at optimization of get_last_activity_info
-		Continue work on last_activity_info caching
-		Fix import error in review_request.py
-		Fix incorrect argument order
-		None handling for changedesc
-		Fetch users in Last Updated By column in one query
-		Add LastUpdatedByColumnTests based on UsernameColumnTests
-		Fix ReviewRequest.set_last_activity_info() failing when user is None
-		Add info on Last Updated By column to dashboard documentation
-		Fix issues with review request closing updating last activity info
-		Handle user being None in ReviewRequest.get_last_activity_user_id()
-		Make ReviewRequest.publish() set updated_object to diffset if it exists
-		Update last activity info when review request is reopened
-		Fix last_updated being set incorrectly after publishing ReviewRequest
-		Send the correct user in ReviewRequestLastUpdateResource
-		Fix ReviewRequest.reopen() setting last activity info after no status change
+		Add a "Last Updated By" column to the dashboard
+		First try at optimization of get_last_activity_info
+		Continue work on last_activity_info caching
+		Fix import error in review_request.py
+		Fix incorrect argument order
+		None handling for changedesc
+		Fetch users in Last Updated By column in one query
+		Add LastUpdatedByColumnTests based on UsernameColumnTests
+		Fix ReviewRequest.set_last_activity_info() failing when user is None
+		Add info on Last Updated By column to dashboard documentation
+		Fix issues with review request closing updating last activity info
+		Handle user being None in ReviewRequest.get_last_activity_user_id()
+		Make ReviewRequest.publish() set updated_object to diffset if it exists
+		Update last activity info when review request is reopened
+		Fix last_updated being set incorrectly after publishing ReviewRequest
+		Send the correct user in ReviewRequestLastUpdateResource
+		Fix ReviewRequest.reopen() setting last activity info after no status change
+		Make changes to address feedback

Diff:

Revision 12 (+952 -186)

Show changes

	docs/manual/users/dashboard/index.rst
	reviewboard/datagrids/columns.py
	reviewboard/datagrids/grids.py
	reviewboard/datagrids/tests.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	reviewboard/reviews/tests/test_review_request.py
	reviewboard/webapi/resources/review_request_last_update.py
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Add a "Last Updated By" column to the dashboard.

Changes

"Last Updated By" column

ReviewRequest last activity info functions

Other

flake8

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commits:

Diff:

Checks run (2 succeeded)

Change Summary:

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Change Summary:

Commits:

Diff:

Checks run (2 succeeded)

Commits:

Diff:

Checks run (2 succeeded)

Change Summary:

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commits:

Diff:

Checks run (2 succeeded)

Commits:

Diff:

Checks run (2 succeeded)

Change Summary:

Summary:

Description:

Changes

"Last Updated By" column

ReviewRequest last activity info functions

Other

Testing Done:

Commits:

Diff:

Checks run (2 succeeded)

Description:

Changes

"Last Updated By" column

ReviewRequest last activity info functions

Other

Change Summary:

Commits:

Diff:

Checks run (2 succeeded)

`ReviewRequest` last activity info functions

`ReviewRequest` last activity info functions

`ReviewRequest` last activity info functions