Summary

Introduce downloadOnly and downloadRbt

Review Request #11677 — Created June 25, 2021 and submitted July 15, 2021, 2:02 p.m.

Information

Owner

misery

Repository

Jenkins plugin

Branch

master

Bugs

Depends On

~~11706~~, ~~11676~~

Reviewers

Groups

rbintegrations

People

Description

If someone will use the system-wide rbt there is no need
to install a user installed rbt again.

Also download of the patch is necessary for binary diffs
or if the repository is in a subdirectory. So applying with "rbt patch"
would fail. This allows so get more control over the patching.

Testing Done

Added plugin to local jenkins. Tried with and without downloadOnly and with and without download Rbt without a problem.

Also added unit tests for it.

Commits

Summary	ID
Introduce downloadOnly and downloadRbt If someone will use the system-wide rbt there is no need to install a user installed rbt again. Also download of the patch is necessary for binary diffs or if the repository is in a subdirectory. So applying with "rbt patch" would fail. This allows so get more control over the patching.	0bad94387379b8b659d83b43ec2973578544dcdf

flake8 passed.

JSHint passed.

Change Summary:

Adjust for /r/11706/

Commits:

	Summary	ID
	Introduce downloadOnly and downloadRbt If someone will use the system-wide rbt there is no need to install a user installed rbt again. Also download of the patch is necessary for binary diffs or if the repository is in a subdirectory. So applying with "rbt patch" would fail. This allows so get more control over the patching.	da6020097daa7d348c3818f66c2891cc19574a00
	Introduce downloadOnly and downloadRbt If someone will use the system-wide rbt there is no need to install a user installed rbt again. Also download of the patch is necessary for binary diffs or if the repository is in a subdirectory. So applying with "rbt patch" would fail. This allows so get more control over the patching.	0bad94387379b8b659d83b43ec2973578544dcdf

Diff:

Revision 2 (+180 -34)

Show changes

	src/main/java/org/reviewboard/rbjenkins/steps/ReviewBoardSetup.java
	src/main/resources/org/reviewboard/rbjenkins/steps/ReviewBoardSetup/config.jelly
	src/main/resources/org/reviewboard/rbjenkins/steps/ReviewBoardSetup/config.properties
	src/test/java/org/reviewboard/rbjenkins/steps/ReviewBoardSetupTest.java

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Depends On:: ~~11706 - Add support for writing patches to a file using rbt patch --write.~~

Ship it!

I'm going to change the RBTools config value to "installRBTools" to be a bit more obvious, and change some of the user-facing text. Otherwise this looks good.

misery July 17, 2021, 6:48 a.m.

Thanks! Did you released it? I don't see a new version here: https://plugins.jenkins.io/rb/

david July 19, 2021, 11:19 a.m.

I'm struggling with authentication on their systems. We'll get it released as soon as I can get my access back.

Status:: Completed
Change Summary:: Pushed to master (00ee66b)